Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

light-client: Optimize voting power calculation by breaking the loop when we have enough voting power #1395

Merged
merged 3 commits into from
Mar 11, 2024
Merged

light-client: Optimize voting power calculation by breaking the loop when we have enough voting power #1395

merged 3 commits into from
Mar 11, 2024

Conversation

i-m-aditya
Copy link
Contributor

@i-m-aditya i-m-aditya commented Feb 22, 2024 •
edited
Loading

Fixes #235

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@i-m-aditya i-m-aditya mentioned this pull request Feb 22, 2024
Merged
3 tasks
@romac romac mentioned this pull request Mar 11, 2024
Closed
@romac romac changed the title optimizing voting power calculation light-client: Optimize voting power calculation by breaking the loop when we have enough voting power Mar 11, 2024
@romac
Copy link
Member

romac commented Mar 11, 2024

Thanks @i-m-aditya! 💐

@romac romac merged commit 27fedbb into informalsystems:main Mar 11, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

light-client: consider optimizing voting power calculation by stopping after verifying +1/3 or +2/3
2 participants
@i-m-aditya @romac