Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tendermint): Make FinalizeBlock::validator_updates nullable when deserializing #1428

Merged
merged 2 commits into from
May 29, 2024
Merged

fix(tendermint): Make FinalizeBlock::validator_updates nullable when deserializing #1428

merged 2 commits into from
May 29, 2024

Conversation

ec2
Copy link
Contributor

@ec2 ec2 commented May 24, 2024 •
edited by romac
Loading

Fixes: #1427

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@romac romac mentioned this pull request May 29, 2024
Open
@romac
Copy link
Member

romac commented May 29, 2024

Thanks for the PR! Can you please a changelog entry in .changelog/unreleased/improvements/?

@romac romac changed the title FinalizeBlock's validator_updates should be nullable fix(tendermint): Make FinalizeBlock::validator_updates nullable when deserializing May 29, 2024
@ec2
Copy link
Contributor Author

ec2 commented May 29, 2024

@romac I've added the changelog :)

romac
romac approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@romac romac merged commit 9697006 into informalsystems:main May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FinalizeBlock Response Deserialization Bug
2 participants
@ec2 @romac