Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix master again #159

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Fix master again #159

merged 1 commit into from
Feb 13, 2020

Conversation

liamsi
Copy link
Member

@liamsi liamsi commented Feb 13, 2020

I should have rebased #155 onto latest master instead. This fixes the build.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGES.md

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@5c3aff6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #159   +/-   ##
=========================================
  Coverage          ?   36.04%           
=========================================
  Files             ?       91           
  Lines             ?     3188           
  Branches          ?      486           
=========================================
  Hits              ?     1149           
  Misses            ?     1774           
  Partials          ?      265

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c3aff6...60d36f8. Read the comment docs.

@Shivani912 Shivani912 merged commit 4eb88a2 into master Feb 13, 2020
@Shivani912 Shivani912 deleted the ismail/fix_master_again branch February 13, 2020 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants