Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON ID specification compatible #202

Merged
merged 5 commits into from
Apr 2, 2020
Merged

JSON ID specification compatible #202

merged 5 commits into from
Apr 2, 2020

Conversation

greg-szabo
Copy link
Member

  • Referenced an issue explaining the need for the change
  • [] Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests (earlier tests still run)
  • Updated CHANGES.md

This is a cherry-pick separation of the JSON ID issue (#88) from the v0.33 branch/PR as requested by @liamsi .

@greg-szabo greg-szabo requested a review from liamsi April 1, 2020 16:51
@greg-szabo greg-szabo mentioned this pull request Apr 1, 2020
Merged
5 tasks
liamsi
liamsi approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @greg-szabo 👍

@greg-szabo greg-szabo merged commit e21179b into master Apr 2, 2020
@greg-szabo greg-szabo deleted the greg/jsonid branch April 2, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamsi liamsi liamsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greg-szabo @liamsi