Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternative to visitor and enum #271

Merged
merged 3 commits into from
May 14, 2020
Merged

Alternative to visitor and enum #271

merged 3 commits into from
May 14, 2020

Conversation

liamsi
Copy link
Member

@liamsi liamsi commented May 14, 2020 •
edited
Loading

Try out if #269 (comment) really works.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGES.md

@liamsi
Try if #269 (comment)
d978c01 
really works
@liamsi liamsi changed the title Alternative to visitor Alternative to visitor and enum May 14, 2020
@liamsi liamsi requested a review from greg-szabo May 14, 2020 10:19
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (greg/serialization-2-alter@5f47467). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                     Coverage Diff                      @@
##             greg/serialization-2-alter    #271   +/-   ##
============================================================
  Coverage                              ?   27.4%           
============================================================
  Files                                 ?      99           
  Lines                                 ?    3694           
  Branches                              ?    1169           
============================================================
  Hits                                  ?    1014           
  Misses                                ?    1870           
  Partials                              ?     810

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f47467...0c43a85. Read the comment docs.

greg-szabo
greg-szabo approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@greg-szabo greg-szabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I'm being schooled here, but it's completely worth it. Awesome solution.

@liamsi liamsi marked this pull request as ready for review May 14, 2020 12:32
@liamsi
Copy link
Member Author

liamsi commented May 14, 2020

Thanks Greg 😊I'll mere it into your branch as is. I think we can slightly improve by aliasing the error imports (currently the full path is used in the code, e.g. serde::de::Error::custom).

@liamsi liamsi merged commit 0ff4ae3 into greg/serialization-2-alter May 14, 2020
@liamsi liamsi deleted the ismail/simplified_null_deserialz branch May 14, 2020 12:36
greg-szabo added a commit that referenced this pull request May 14, 2020
@greg-szabo @liamsi
Serialization refactor step 2 (#269)
c2f3118 
* Added byte array serializer with the option to interpret null as empty array.
* Update documentation on serializers
* Updated CHANGES.md
* Alternative to visitor and enum (#271)

Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-szabo greg-szabo greg-szabo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liamsi @codecov-io @greg-szabo