Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symmetric assertions to unit tests #283

Merged
merged 3 commits into from
May 27, 2020
Merged

Symmetric assertions to unit tests #283

merged 3 commits into from
May 27, 2020

Conversation

greg-szabo
Copy link
Member

Fixes #261
Reimplements #98 because of too many changes from master.

Note: #98 is @yihuang 's PR and I want to credit him with the findings. Cherry-picking his changes to master didn't work out, too many files changed since he opened the PR.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGES.md

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@greg-szabo greg-szabo requested a review from liamsi May 27, 2020 00:29
@codecov-commenter
Copy link

Codecov Report

Merging #283 into master will decrease coverage by 0.2%.
The diff coverage is 32.2%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #283     +/-   ##
========================================
- Coverage    27.7%   27.5%   -0.3%     
========================================
  Files         106     106             
  Lines        3861    3826     -35     
  Branches     1223    1205     -18     
========================================
- Hits         1072    1054     -18     
- Misses       1917    1922      +5     
+ Partials      872     850     -22     
Impacted Files Coverage Δ
tendermint/src/block.rs 0.0% <ø> (ø)
tendermint/src/serializers/custom.rs 16.1% <20.0%> (-4.6%) ⬇️
tendermint/src/serializers/tests.rs 59.2% <43.7%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afb11bf...15abc7b. Read the comment docs.

Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍Thanks @greg-szabo 👍

@liamsi liamsi merged commit 4e179c9 into master May 27, 2020
@liamsi liamsi deleted the greg/symser-261 branch May 27, 2020 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serialization testing - symmetric assertions to the unit tests
3 participants