[light-client] Supervisor #302
Conversation
romac
commented
Jun 5, 2020
romac
commented
- Referenced an issue explaining the need for the change
- Updated all relevant documentation in docs
- Updated all code comments where relevant
- Wrote tests
- Updated CHANGES.md
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
========================================
- Coverage 30.5% 28.2% -2.3%
========================================
Files 127 130 +3
Lines 4581 4880 +299
Branches 1416 1511 +95
========================================
- Hits 1398 1378 -20
- Misses 2216 2533 +317
- Partials 967 969 +2
Continue to review full report at Codecov.
|
|
|
||
| state | ||
| .light_store | ||
| .update(trusted_state.clone(), VerifiedStatus::Verified); |
There was a problem hiding this comment.
why do we update the current state to verified here? not sure I understand
There was a problem hiding this comment.
The light client needs to have at least one trusted (Verified) block to perform verification.
We should perhaps provide a nicer API on State for interacting with the store, and make such things more explicit and higher-level.
light-client/src/supervisor.rs
Outdated
| trusted_state: &LightBlock, | ||
| ) -> Result<Option<Vec<Fork>>, Error> { | ||
| if self.peers.secondaries().is_empty() { | ||
| return Ok(None); |
There was a problem hiding this comment.
this seems very insecure to me.. even though we rely on 1 correct node assumption, my personal opinion is that we need at least 1 witness. we can't assume primary will always be correct.
