Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate and delete old implementation of the light client #500

Merged
merged 7 commits into from
Aug 5, 2020
Merged

Consolidate and delete old implementation of the light client #500

merged 7 commits into from
Aug 5, 2020

Conversation

romac
Copy link
Member

@romac romac commented Aug 3, 2020 •
edited
Loading

Close #437

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

@romac romac added the light-client Issues/features which involve the light client label Aug 3, 2020
@romac romac requested review from liamsi, xla and ebuchman and removed request for liamsi and xla August 3, 2020 18:32
liamsi
liamsi reviewed Aug 4, 2020
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍 Left two minor comments

liamsi
liamsi previously approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff 👍 Looking forward to the next release :-)

xla
xla previously approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra dope!

🍍 👪 📸 🗽

light-client/src/operations/hasher.rs Outdated Show resolved Hide resolved
light-client/src/predicates.rs Outdated Show resolved Hide resolved
@romac @xla
Re-order derived traits
1295937 
Co-authored-by: Alexander Simmerl <a.simmerl@gmail.com>
@romac romac dismissed stale reviews from xla and liamsi via 1295937 August 5, 2020 09:58
@romac romac requested a review from xla August 5, 2020 09:59
xla
xla approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌸 🌯 ♎️ 🐅

@brapse brapse merged commit 5e29872 into master Aug 5, 2020
@brapse brapse deleted the romain/cleanup-tmlite branch August 5, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamsi liamsi liamsi left review comments

@xla xla xla approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
light-client Issues/features which involve the light client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

light-client: consolidate and delete old implementations
4 participants
@romac @xla @liamsi @brapse