Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: Upgrade WebSocketClient to support full client functionality #646

Merged
merged 21 commits into from
Nov 26, 2020
Merged

rpc: Upgrade WebSocketClient to support full client functionality #646

merged 21 commits into from
Nov 26, 2020

Commits on Oct 20, 2020

  1. Expand WebSocket functionality 

    This commit is multi-faceted. It:

1. Drastically simplifies much of the subscription-related
   functionality.
2. Expands the WebSocketClient's capabilities to be able to handle other
   types of requests other than just subscriptions (i.e. it implements the
   Client trait).

Signed-off-by: Thane Thomson <connect@thanethomson.com>
    @thanethomson
    thanethomson committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    84fea8b View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2020

  1. Merge latest changes from master 

    Signed-off-by: Thane Thomson <connect@thanethomson.com>
    @thanethomson
    thanethomson committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    68b7a82 View commit details
    Browse the repository at this point in the history

  2. The http-client feature also needs the tracing lib 

    Signed-off-by: Thane Thomson <connect@thanethomson.com>
    @thanethomson
    thanethomson committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    eef3d7b View commit details
    Browse the repository at this point in the history

  3. Make client mutable in example 

    Signed-off-by: Thane Thomson <connect@thanethomson.com>
    @thanethomson
    thanethomson committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    b862804 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2020

  1. Merge latest changes from master 

    Signed-off-by: Thane Thomson <connect@thanethomson.com>
    @thanethomson
    thanethomson committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    6da9857 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG 

    Signed-off-by: Thane Thomson <connect@thanethomson.com>
    @thanethomson
    thanethomson committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    e81759c View commit details
    Browse the repository at this point in the history

  3. Update ADR-008 to reflect recent changes 

    Signed-off-by: Thane Thomson <connect@thanethomson.com>
    @thanethomson
    thanethomson committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    b938499 View commit details
    Browse the repository at this point in the history

  4. Fix minor bug in response handling 

    Signed-off-by: Thane Thomson <connect@thanethomson.com>
    @thanethomson
    thanethomson committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    c384205 View commit details
    Browse the repository at this point in the history

  5. Update tests to use new WebSocketClient functionality 

    Signed-off-by: Thane Thomson <connect@thanethomson.com>
    @thanethomson
    thanethomson committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    5bf8074 View commit details
    Browse the repository at this point in the history

  6. Fix/ignore clippy warnings 

    Signed-off-by: Thane Thomson <connect@thanethomson.com>
    @thanethomson
    thanethomson committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    8f5fb24 View commit details
    Browse the repository at this point in the history

  7. Fix documentation for rpc crate 

    Signed-off-by: Thane Thomson <connect@thanethomson.com>
    @thanethomson
    thanethomson committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    f04b8b4 View commit details
    Browse the repository at this point in the history

  8. Fix broken link in crate docs 

    Signed-off-by: Thane Thomson <connect@thanethomson.com>
    @thanethomson
    thanethomson committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    f6eaf88 View commit details
    Browse the repository at this point in the history

  9. Update RPC repo docs 

    Signed-off-by: Thane Thomson <connect@thanethomson.com>
    @thanethomson
    thanethomson committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    cb82342 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2020

  1. Merge latest changes from master 

    Signed-off-by: Thane Thomson <connect@thanethomson.com>
    @thanethomson
    thanethomson committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    0658499 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2020

  1. Merge latest changes from master 

    Signed-off-by: Thane Thomson <connect@thanethomson.com>
    @thanethomson
    thanethomson committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    bf1565e View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2020

  1. Merge latest changes from master 

    Signed-off-by: Thane Thomson <connect@thanethomson.com>
    @thanethomson
    thanethomson committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    c2c3528 View commit details
    Browse the repository at this point in the history

  2. Refactor to remove ChannelTx mutability 

    ChannelTx::send now no longer needs to be mutable because the underlying
channel has no mutability requirement. This leads to viral changes
throughout the interfaces and clients (positive ones).

ChannelTx::send also doesn't need to be async, because it relies on an
unbounded channel. This also has some viral implications for other
methods throughout the RPC client. If, in future, we want to support
bounded channels, then we can consider making it async again. But we
probably shouldn't make it async if we don't need it to be.

Signed-off-by: Thane Thomson <connect@thanethomson.com>
    @thanethomson
    thanethomson committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    56ce9f4 View commit details
    Browse the repository at this point in the history

  3. Client no longer needs to be mutable 

    Signed-off-by: Thane Thomson <connect@thanethomson.com>
    @thanethomson
    thanethomson committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    741cecb View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2020

  1. Use explicit borrow_mut to avoid having to obtain subscriptions map t… 

    …wice

Signed-off-by: Thane Thomson <connect@thanethomson.com>
    @thanethomson
    thanethomson committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    eefced1 View commit details
    Browse the repository at this point in the history

  2. Rename method for clarity 

    Signed-off-by: Thane Thomson <connect@thanethomson.com>
    @thanethomson
    thanethomson committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    62cbdca View commit details
    Browse the repository at this point in the history

  3. Merge latest changes from master 

    Signed-off-by: Thane Thomson <connect@thanethomson.com>
    @thanethomson
    thanethomson committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    281a0a8 View commit details
    Browse the repository at this point in the history