Move time proptest generators into their own crate #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging in @Shivani912 for review since I think this might help with code reuse in ongoing work? |
Shivani912
suggested changes
Mar 17, 2021
There was a problem hiding this comment.
Thanks @shonfeder ! It's great we now have a crate for this. I was indeed looking forward to it :))
I have one small comment, otherwise looks good to me!
Shivani912
previously approved these changes
Mar 17, 2021
Co-authored-by: Thane Thomson <thane@informal.systems>
Co-authored-by: Thane Thomson <thane@informal.systems>
romac
reviewed
Mar 18, 2021
thanethomson
added a commit
that referenced
this pull request
Mar 30, 2021
* Move time proptest generators into their own crate Closes #828 This allows us to use the timestamp and DateTime generators in any other crate in our workspace. It should help advance #822 and #821. * Fix clippy warning * Correct documentation example * Update pbt-gen/src/time.rs Co-authored-by: Thane Thomson <thane@informal.systems> * Update pbt-gen/src/time.rs Co-authored-by: Thane Thomson <thane@informal.systems> * Fix typos in pbt-gen/Cargo.toml * Rename pbt-gen crate and guard modules with feature * Correct wording Co-authored-by: Thane Thomson <thane@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #828
This allows us to use the timestamp and DateTime generators in any other
crate in our workspace. It should help advance #822 and #821.