Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily remove RPC query parsing #858

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

thanethomson
Copy link
Contributor

Closes #857.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson requested a review from romac April 6, 2021 22:17
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release/v0.19.0@d716d81). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             release/v0.19.0    #858   +/-   ##
=================================================
  Coverage                   ?   66.8%           
=================================================
  Files                      ?     211           
  Lines                      ?   16745           
  Branches                   ?       0           
=================================================
  Hits                       ?   11202           
  Misses                     ?    5543           
  Partials                   ?       0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d716d81...a1a9968. Read the comment docs.

@thanethomson thanethomson merged commit 81cd4fe into release/v0.19.0 Apr 7, 2021
@thanethomson thanethomson deleted the thane/857-rust-peg branch April 7, 2021 00:18
thanethomson added a commit that referenced this pull request Apr 7, 2021
* Update changelog for v0.19.0 release

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Bump versions to v0.19.0

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add minor documentation for tendermint-light-client-js crate

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add abci and light-client-js crates to release script

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add cargo metadata for abci and light-client-js

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Fix keywords in abci and light-client-js crates

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* rpc: add `Client::wait_until_healthy` method (#855)

Adds a method which repeatedly polls the `/health` endpoint until it
returns a successful response or a specified timeout elapses.

This is useful when writing tests that need to wait for a node to boot
up (e.g. inside of a docker container).

* Temporarily remove RPC query parsing (#858)

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add CHANGELOG entry for #855

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Co-authored-by: Tony Arcieri (iqlusion) <tony@iqlusion.io>
@thanethomson thanethomson mentioned this pull request Aug 10, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants