Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily revert #926 #928

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Temporarily revert #926 #928

merged 1 commit into from
Jul 13, 2021

Conversation

thanethomson
Copy link
Contributor

@thanethomson thanethomson commented Jul 13, 2021

As per #925 (comment), we'll reintroduce these changes once the issue's fixed in Prost v0.8.

The audit check will necessarily fail, since we're going back to using Prost v0.7 for now.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

This temporarily reverts commit
1efe42c. We'll reintroduce these
changes when tokio-rs/prost#502 is fixed.

Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson merged commit 1a7c160 into master Jul 13, 2021
@thanethomson thanethomson deleted the thane/926-revert branch July 13, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants