Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OP-1193 | OP-1194 | OP-1197 | OP-1198 | Update, Delete and validate Ward inventory #2085

Open
wants to merge 53 commits into
base: OP-1200-Wards-Inventory
Choose a base branch
from
Open

OP-1193 | OP-1194 | OP-1197 | OP-1198 | Update, Delete and validate Ward inventory #2085

wants to merge 53 commits into from

Conversation

JantBogard
Copy link

@JantBogard JantBogard commented Nov 12, 2024 •
edited by mwithi
Loading

@mwithi
Copy link
Member

mwithi commented Nov 12, 2024

Please @JantBogard resolve conflicts with the update base branch

JantBogard and others added 9 commits November 25, 2024 14:55
@JantBogard
formating
4343b0c
@JantBogard
formatting
454edcc
@JantBogard
Fix format issues
b84bc5b
@JantBogard
Merge branch 'develop' into OP-1193_OP-1194_OP-1197
1e22eae
@JantBogard
Fix format issues
146f929
@SteveGT96
OP-1043 | Remove deleted group from user edit group jcombo box (infor…
fed3d55 
…matici#2096)

* fix(OP-1043): Remove deleted group from user edit group jcombo box

* chore: Reformat code

---------

Co-authored-by: SteveGT96 <steve.tsala@intesys.it>
@mohit10696
OP-1341 Enable Medical Type for Soft Deletion (informatici#2092)
d246186 
* Added option to mark medical type as active and add filter

* Title fixed

* Updated the CORE call to new type

* Fixed text
@dbmalkovsky
Chore: add missing @OverRide annotation (informatici#2097)
a4f6d71
@JantBogard
Fix format issues
29293c1
@mwithi
Copy link
Member

mwithi commented Dec 7, 2024

Please make possible to add ANY specific products (show the full list of not-deleted medicals)

image

@JantBogard
Copy link
Author

Please make possible to add ANY specific products (show the full list of not-deleted medicals)

image

Resolved

@mwithi
Copy link
Member

mwithi commented Dec 17, 2024

Found that Lot information is not saved:

Lot information inserted (note: empty code should be managed as AUTO)
image

Save
image

Press no
image

Edit
image

Lot information missing
image

@mwithi
Copy link
Member

mwithi commented Jan 8, 2025

It seems quite ok now, only one thing: a product with a new lot N should not be allowed with zero real quantity (because it doesn't make sense to define a new lot in that case).

@ArnaudFofou please can you verify that behaviour is at least similar with the already merged work of OP-1199?

@JantBogard
Copy link
Author

JantBogard commented Jan 9, 2025 •
edited by jira bot
Loading

It seems quite ok now, only one thing: a product with a new lot N should not be allowed with zero real quantity (because it doesn't make sense to define a new lot in that case).

@ArnaudFofou please can you verify that behaviour is at least similar with the already merged work of OP-1199?

I fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArnaudFofou ArnaudFofou ArnaudFofou approved these changes

@mwithi mwithi mwithi approved these changes

@dbmalkovsky dbmalkovsky Awaiting requested review from dbmalkovsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JantBogard @mwithi @dbmalkovsky @ArnaudFofou @SteveGT96 @mohit10696