OP-1199 Small improvements #2107
Conversation
| jTableInventory.getColumnModel().getColumn(i).setMinWidth(pColumwidth[i]); | ||
| } | ||
| } | ||
|
|
||
| private JComboBox<String> getComboBox() { | ||
| if (statusComboBox == null) { | ||
| statusComboBox = new JComboBox<String>(); |
There was a problem hiding this comment.
| statusComboBox = new JComboBox<String>(); | |
| statusComboBox = new JComboBox<>(); |
Replace explicit type object with <>
| }); | ||
| pagesCombo.addItemListener(new ItemListener() { | ||
| pagesComboBox.addItemListener(new ItemListener() { |
There was a problem hiding this comment.
anonymous type can be replaced by a lambda (starting with JDK 8)
| } else { | ||
| jTableInventory.getColumnModel().getColumn(i).setCellRenderer(new ColorTableCellRenderer()); | ||
| } | ||
| } | ||
| jTableInventory.getSelectionModel().addListSelectionListener(new ListSelectionListener() { |
There was a problem hiding this comment.
anonymous type can be replaced by a lambda (starting with JDK 8)
| } | ||
|
|
||
| ofPagesLabel.setText("/" + totalPages + " " + MessageBundle.getMessage("angal.common.pages.txt")); |
There was a problem hiding this comment.
first single character strings can just use single quotes
second why not use a formatted message that will move the need for two concatenations
Something like:
angal.common.pages.fmt.txt = /{0} Pages
| startIndex = 0; | ||
| int page = startIndex / PAGE_SIZE + 1; |
There was a problem hiding this comment.
The result of startIndex / PAGE_SIZE is always zero (startIndex is 0). So the result is always 1.
| private boolean[] columnCentered = { false, false, false, true, true, true, true, true, true, true }; | ||
| private boolean[] columnDecimalNumber = { false, false, false, false, false, false, false, false, true, true }; | ||
| private Class< ? >[] columnsClasses = { String.class, Integer.class, String.class, String.class, String.class, LocalDate.class, Integer.class, | ||
| Integer.class, BigDecimal.class, BigDecimal.class }; | ||
| private MedicalInventory inventory = null; |
There was a problem hiding this comment.
| private MedicalInventory inventory = null; | |
| private MedicalInventory inventory; |
Initialization to null is redundant
There are at least 7 other occurrences.
|
Generally it looks OK but the code (especially the original code) has many code implementation issues. I only marked those that I could see in the diff from this PR. Remind me when this gets merged to go back and really go other the code constructs and newer language level options. |
Small improvements for OP-1199.