Cloning fixes #172
Merged
Cloning fixes #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. simplify handling of special ermrest tables using onconflict=skip 2. defer acl_bindings until after fkeys are provisioned 3. add ERMrest_RID_Lease handling to skip data cloning
The original cloning logic failed to account for applying configuration changes to tables that already exist in the destination catalog. This is usually just the built-in ERMrest tables in the public schema, but could include others if the caller supplies the destination catalog as an input argument. To be safe, apply all configuration again in the final phase. The normal apply() logic tries to avoid unnecessary requests and so should be efficient. Also, we do not want to revert the cloning status state value already written into the destination table annotations by earlier clone processing stages, so that gets special handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.