add CLUSTER INFO command and use it for new checkedConnectCluster #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redis nodes in cluster mode can be pinged, but a successful pong from one cluster node would not determine whether the cluster and thus all its nodes are up and running. The cluster is up only if the `CLUSTER INFO` command reports `cluster_state:ok`. This PR adds the `CLUSTER INFO` command and the `checkedConnectCluster` helper function for safely connecting to Redis clusters only when the cluster is up.
|
Related to #183. |
|
@jbrechtel, what do you think? |
|
Hello, @stefanwire! Thanks for your work and sorry for a late reply I've used your branch merged with latest master and tried to run cluster tests there. If you are still interested in this issue and Redis cluster support can you take a look into that. Maybe I'm just running it in the wrong way. I've run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redis nodes in cluster mode can be pinged, but a successful pong from one
cluster node would not determine whether the cluster and thus all its nodes are
up and running. The cluster is up only if the
CLUSTER INFOcommand reportscluster_state:ok.This PR adds the
CLUSTER INFOcommand and thecheckedConnectClusterhelperfunction for safely connecting to Redis clusters only when the cluster is up.