Skip to content

Commit

Permalink
Skip upstream openjdk entrypoint
Browse files Browse the repository at this point in the history
The upstream entrypoint is `sh` and so loses dotted environment variables, lets prevent that from happening by just skipping it as the `tomcat` images isn't reliant on its functionality (docker-library/docs#2338).

Fixes docker-library#302 which is a recurrence of docker-library#77
  • Loading branch information
yosifkit committed Aug 11, 2023
1 parent c0878b7 commit 9104471
Show file tree
Hide file tree
Showing 29 changed files with 176 additions and 0 deletions.
6 changes: 6 additions & 0 deletions 10.1/jdk11/temurin-jammy/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 10.1/jdk17/temurin-jammy/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 10.1/jre11/temurin-jammy/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 10.1/jre17/temurin-jammy/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 8.5/jdk11/temurin-focal/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 8.5/jdk11/temurin-jammy/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 8.5/jdk17/temurin-focal/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 8.5/jdk17/temurin-jammy/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 8.5/jdk8/temurin-focal/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 8.5/jdk8/temurin-jammy/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 8.5/jre11/temurin-focal/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 8.5/jre11/temurin-jammy/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 8.5/jre17/temurin-focal/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 8.5/jre17/temurin-jammy/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 8.5/jre8/temurin-focal/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 8.5/jre8/temurin-jammy/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 9.0/jdk11/temurin-focal/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 9.0/jdk11/temurin-jammy/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 9.0/jdk17/temurin-focal/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 9.0/jdk17/temurin-jammy/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 9.0/jdk8/temurin-focal/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 9.0/jdk8/temurin-jammy/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 9.0/jre11/temurin-focal/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 9.0/jre11/temurin-jammy/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 9.0/jre17/temurin-focal/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 9.0/jre17/temurin-jammy/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 9.0/jre8/temurin-focal/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions 9.0/jre8/temurin-jammy/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions Dockerfile.template
Original file line number Diff line number Diff line change
Expand Up @@ -277,4 +277,12 @@ RUN set -eux; \
fi

EXPOSE 8080
{{ if vendor_variant | contains("temurin") then ( -}}

# upstream eclipse-temurin-provided script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302
# use "/entrypoint.sh" at your own risk
# see also https://github.com/docker-library/docs/pull/2338 https://github.com/adoptium/containers/pull/392
ENTRYPOINT []

{{ ) else "" end -}}
CMD ["catalina.sh", "run"]

0 comments on commit 9104471

Please sign in to comment.