bug: while using gzip and call with MaxCallRecvMsgSize(math.MaxInt64) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infovivek2020
force-pushed
the
bugfix-gzip-no-byte-read-max-int
branch
from
d6c4beb to
97e8e19
Compare
|
@purnesh Please look |
|
@infovivek2020 so just to confirm you are saying that this issue exist currently but goes away with your fix https://github.com/grpc/grpc-go/issues/4552? |
|
yes @purnesh42H |
You can mention in the issue grpc#6119 that it is duplicate of grpc#4552 and your PR also fixes it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
in the helloworld greeter client and server we are using this as argument to reproduce issue grpc.MaxCallRecvMsgSize(math.MaxInt)
What does this PR do.
right now tried to repro
Release Notes
none