Allows custom message and date format. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 30, 2014 11:32
…MESSAGE_FORMATTER’] and custom date format via os.environment[‘SYSLOG_DATE_FORMATTER’]
| def message_format(self): | ||
| fmt = os.environ.get( | ||
| 'SYSLOG_MESSAGE_FORMAT', | ||
| self.__class__.DFLT_MSG_FORMAT |
There was a problem hiding this comment.
Why not self.DFLT_MSG_FORMAT (here and below)?
There was a problem hiding this comment.
Log routers such as Heka or Logstash are picky about which syslog RFC it is accepting.
So I figured why not let user defines which format they want through os.environ[SYSLOG_MESSAGE_FORMAT]
There was a problem hiding this comment.
I see the reason; I'm just saying you shouldn't use .__class__ here.
There was a problem hiding this comment.
Would that work? message_format is an instance method and DEFAULT_MESSAGE_FORMAT is class variable.
|
added 9 commits
July 30, 2014 17:06
|
@koterpillar Looks like Travis is not pointing at the right Git repo. |
|
It is correctly merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also sets default syslog endpoint values to:
udp:localhost:514. Ref: #2