Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag input for comment action #35

Merged
merged 2 commits into from
Dec 15, 2021
Merged

Add tag input for comment action #35

merged 2 commits into from
Dec 15, 2021

Conversation

aliscott
Copy link
Member

No description provided.

@aliscott aliscott changed the title feat: add tag input for comment action Add tag input for comment action Dec 14, 2021
@github-actions
Copy link

💰 Infracost estimate: monthly cost will increase by $55,065 📈

Project Previous New Diff
infracost/infracost/examples/terraform/plan.json $0 $55,065 +$55,065
Infracost output
Project: infracost/infracost/examples/terraform/plan.json

+ aws_instance.web_app
  +$55,065

    + Instance usage (Linux/UNIX, on-demand, m5.4xlarge)
      +$41,570

    + root_block_device
    
        + Storage (general purpose SSD, gp2)
          +$371

    + ebs_block_device[0]
    
        + Storage (provisioned IOPS SSD, io1)
          +$9,268
    
        + Provisioned IOPS
          +$3,856

+ aws_lambda_function.hello_world
  Monthly cost depends on usage

    + Requests
      Monthly cost depends on usage
        +$14.83 per 1M requests

    + Duration
      Monthly cost depends on usage
        +$0.0012357988 per GB-seconds

Monthly cost change for infracost/infracost/examples/terraform/plan.json
Amount:  +$55,065 ($0.00 → $55,065)

──────────────────────────────────
Key: ~ changed, + added, - removed

2 cloud resources were detected:
∙ 2 were estimated, 2 include usage-based costs, see https://infracost.io/usage-file

This comment will be updated when the cost estimate changes.

Is this comment useful? Yes, No

@tim775
Copy link
Member

tim775 commented Dec 14, 2021

We should also update the get-comment action

@aliscott aliscott marked this pull request as ready for review December 15, 2021 11:59
@aliscott aliscott requested a review from tim775 December 15, 2021 11:59
@aliscott aliscott self-assigned this Dec 15, 2021
comment/README.md Outdated Show resolved Hide resolved
Copy link
Member

@tim775 tim775 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make parallel changes to get-comment

Copy link
Member

@tim775 tim775 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I added fe4c43d

@aliscott aliscott merged commit 12f02b7 into master Dec 15, 2021
@aliscott aliscott deleted the comment-tag branch December 15, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants