Fix/comment actions #57

hugorut · 2022-03-11T13:47:05Z

Changes are in 95ba41f Ignore docs commit. This has been created off a yet merged PR.

Changes comment-action to use infracost comment
Updates examples to use infracost comment and adds deprecation warning
Updates tests

Pipeline was succeeding until I mucked around with the comments (deleting them on a certain commit) and now the commit action fails with this:

time="2022-03-11T14:26:29Z" level=info msg="Finding matching comments for tag infracost-commit"
Error: Type mismatch on variable $commitSha and argument oid (String! / GitObjectID)
Error: Process completed with exit code 1.

^I'm pretty sure this is because of the state of the PR and will disappear with merging.

github-actions · 2022-03-11T14:14:27Z

💰 Infracost estimate: monthly cost will increase by $55,065 📈

Project	Previous	New	Diff
infracost/infracost/examples/terraform/plan.json	$0	$55,065	+$55,065

Infracost output

Project: infracost/infracost/examples/terraform/plan.json

+ aws_instance.web_app
  +$55,065

    + Instance usage (Linux/UNIX, on-demand, m5.4xlarge)
      +$41,570

    + root_block_device
    
        + Storage (general purpose SSD, gp2)
          +$371

    + ebs_block_device[0]
    
        + Storage (provisioned IOPS SSD, io1)
          +$9,268
    
        + Provisioned IOPS
          +$3,856

+ aws_lambda_function.hello_world
  Monthly cost depends on usage

    + Requests
      Monthly cost depends on usage
        +$14.83 per 1M requests

    + Duration
      Monthly cost depends on usage
        +$0.0012357988 per GB-seconds

Monthly cost change for infracost/infracost/examples/terraform/plan.json
Amount:  +$55,065 ($0.00 → $55,065)

──────────────────────────────────
Key: ~ changed, + added, - removed

2 cloud resources were detected:
∙ 2 were estimated, 2 include usage-based costs, see https://infracost.io/usage-file

_{Is this comment useful? Yes, No}

github-actions · 2022-03-11T14:21:51Z

💰 Infracost estimate: monthly cost will increase by $55,065 📈

Project	Previous	New	Diff
infracost/infracost/examples/terraform/plan.json	$0	$55,065	+$55,065

Infracost output

Project: infracost/infracost/examples/terraform/plan.json

+ aws_instance.web_app
  +$55,065

    + Instance usage (Linux/UNIX, on-demand, m5.4xlarge)
      +$41,570

    + root_block_device
    
        + Storage (general purpose SSD, gp2)
          +$371

    + ebs_block_device[0]
    
        + Storage (provisioned IOPS SSD, io1)
          +$9,268
    
        + Provisioned IOPS
          +$3,856

+ aws_lambda_function.hello_world
  Monthly cost depends on usage

    + Requests
      Monthly cost depends on usage
        +$14.83 per 1M requests

    + Duration
      Monthly cost depends on usage
        +$0.0012357988 per GB-seconds

Monthly cost change for infracost/infracost/examples/terraform/plan.json
Amount:  +$55,065 ($0.00 → $55,065)

──────────────────────────────────
Key: ~ changed, + added, - removed

2 cloud resources were detected:
∙ 2 were estimated, 2 include usage-based costs, see https://infracost.io/usage-file

This comment will be updated when the cost estimate changes.

_{Is this comment useful? Yes, No}

github-actions · 2022-03-11T14:26:51Z

💰 Infracost estimate: monthly cost will increase by $55,065 📈

Project	Previous	New	Diff
infracost/infracost/examples/terraform/plan.json	$0	$55,065	+$55,065

Infracost output

Project: infracost/infracost/examples/terraform/plan.json

+ aws_instance.web_app
  +$55,065

    + Instance usage (Linux/UNIX, on-demand, m5.4xlarge)
      +$41,570

    + root_block_device
    
        + Storage (general purpose SSD, gp2)
          +$371

    + ebs_block_device[0]
    
        + Storage (provisioned IOPS SSD, io1)
          +$9,268
    
        + Provisioned IOPS
          +$3,856

+ aws_lambda_function.hello_world
  Monthly cost depends on usage

    + Requests
      Monthly cost depends on usage
        +$14.83 per 1M requests

    + Duration
      Monthly cost depends on usage
        +$0.0012357988 per GB-seconds

Monthly cost change for infracost/infracost/examples/terraform/plan.json
Amount:  +$55,065 ($0.00 → $55,065)

──────────────────────────────────
Key: ~ changed, + added, - removed

2 cloud resources were detected:
∙ 2 were estimated, 2 include usage-based costs, see https://infracost.io/usage-file

_{Is this comment useful? Yes, No}

comment/action.yml

.github/workflows/comment_test.yml

scripts/generateExamplesTests.js

examples/terraform-cloud-enterprise/README.md

github-actions · 2022-03-15T11:02:01Z

💰 Infracost estimate: monthly cost will increase by $55,065 📈

Project	Previous	New	Diff
infracost/infracost/examples/terraform/plan.json	$0	$55,065	+$55,065

Infracost output

Project: infracost/infracost/examples/terraform/plan.json

+ aws_instance.web_app
  +$55,065

    + Instance usage (Linux/UNIX, on-demand, m5.4xlarge)
      +$41,570

    + root_block_device
    
        + Storage (general purpose SSD, gp2)
          +$371

    + ebs_block_device[0]
    
        + Storage (provisioned IOPS SSD, io1)
          +$9,268
    
        + Provisioned IOPS
          +$3,856

+ aws_lambda_function.hello_world
  Monthly cost depends on usage

    + Requests
      Monthly cost depends on usage
        +$14.83 per 1M requests

    + Duration
      Monthly cost depends on usage
        +$0.0012357988 per GB-seconds

Monthly cost change for infracost/infracost/examples/terraform/plan.json
Amount:  +$55,065 ($0.00 → $55,065)

──────────────────────────────────
Key: ~ changed, + added, - removed

2 cloud resources were detected:
∙ 2 were estimated, 2 include usage-based costs, see https://infracost.io/usage-file

_{Is this comment useful? Yes, No}

github-actions · 2022-03-15T11:02:24Z

💰 Infracost estimate: monthly cost will increase by $55,065 📈

Project	Previous	New	Diff
infracost/infracost/examples/terraform/plan.json	$0	$55,065	+$55,065

Infracost output

Project: infracost/infracost/examples/terraform/plan.json

+ aws_instance.web_app
  +$55,065

    + Instance usage (Linux/UNIX, on-demand, m5.4xlarge)
      +$41,570

    + root_block_device
    
        + Storage (general purpose SSD, gp2)
          +$371

    + ebs_block_device[0]
    
        + Storage (provisioned IOPS SSD, io1)
          +$9,268
    
        + Provisioned IOPS
          +$3,856

+ aws_lambda_function.hello_world
  Monthly cost depends on usage

    + Requests
      Monthly cost depends on usage
        +$14.83 per 1M requests

    + Duration
      Monthly cost depends on usage
        +$0.0012357988 per GB-seconds

Monthly cost change for infracost/infracost/examples/terraform/plan.json
Amount:  +$55,065 ($0.00 → $55,065)

──────────────────────────────────
Key: ~ changed, + added, - removed

2 cloud resources were detected:
∙ 2 were estimated, 2 include usage-based costs, see https://infracost.io/usage-file

_{Is this comment useful? Yes, No}

vdmgolub

Looks great! 🚀

github-actions · 2022-03-16T17:06:00Z

💰 Infracost estimate: monthly cost will increase by $55,065 📈

Project	Previous	New	Diff
infracost/infracost/examples/terraform/plan.json	$0	$55,065	+$55,065

Infracost output

Project: infracost/infracost/examples/terraform/plan.json

+ aws_instance.web_app
  +$55,065

    + Instance usage (Linux/UNIX, on-demand, m5.4xlarge)
      +$41,570

    + root_block_device
    
        + Storage (general purpose SSD, gp2)
          +$371

    + ebs_block_device[0]
    
        + Storage (provisioned IOPS SSD, io1)
          +$9,268
    
        + Provisioned IOPS
          +$3,856

+ aws_lambda_function.hello_world
  Monthly cost depends on usage

    + Requests
      Monthly cost depends on usage
        +$14.83 per 1M requests

    + Duration
      Monthly cost depends on usage
        +$0.0012357988 per GB-seconds

Monthly cost change for infracost/infracost/examples/terraform/plan.json
Amount:  +$55,065 ($0.00 → $55,065)

──────────────────────────────────
Key: ~ changed, + added, - removed

2 cloud resources were detected:
∙ 2 were estimated, 2 include usage-based costs, see https://infracost.io/usage-file

_{Is this comment useful? Yes, No}

github-actions · 2022-03-16T17:06:01Z

💰 Infracost estimate: monthly cost will increase by $55,065 📈

Project	Previous	New	Diff
infracost/infracost/examples/terraform/plan.json	$0	$55,065	+$55,065

Infracost output

Project: infracost/infracost/examples/terraform/plan.json

+ aws_instance.web_app
  +$55,065

    + Instance usage (Linux/UNIX, on-demand, m5.4xlarge)
      +$41,570

    + root_block_device
    
        + Storage (general purpose SSD, gp2)
          +$371

    + ebs_block_device[0]
    
        + Storage (provisioned IOPS SSD, io1)
          +$9,268
    
        + Provisioned IOPS
          +$3,856

+ aws_lambda_function.hello_world
  Monthly cost depends on usage

    + Requests
      Monthly cost depends on usage
        +$14.83 per 1M requests

    + Duration
      Monthly cost depends on usage
        +$0.0012357988 per GB-seconds

Monthly cost change for infracost/infracost/examples/terraform/plan.json
Amount:  +$55,065 ($0.00 → $55,065)

──────────────────────────────────
Key: ~ changed, + added, - removed

2 cloud resources were detected:
∙ 2 were estimated, 2 include usage-based costs, see https://infracost.io/usage-file

_{Is this comment useful? Yes, No}

hugorut force-pushed the fix/comment-actions branch from c104ebc to 30ebc14 Compare March 11, 2022 13:51

$@infracost$ infracost deleted a comment from github-actions bot Mar 11, 2022

hugorut force-pushed the fix/comment-actions branch 2 times, most recently from facfccd to aaa17aa Compare March 11, 2022 14:01

hugorut force-pushed the fix/comment-actions branch from aaa17aa to 95ba41f Compare March 11, 2022 14:26

hugorut requested a review from vdmgolub March 11, 2022 14:29

hugorut self-assigned this Mar 11, 2022

hugorut marked this pull request as ready for review March 11, 2022 14:30

vdmgolub reviewed Mar 14, 2022

View reviewed changes

hugorut force-pushed the fix/comment-actions branch from 95ba41f to 466dd8e Compare March 15, 2022 11:01

hugorut requested a review from vdmgolub March 15, 2022 11:07

vdmgolub approved these changes Mar 15, 2022

View reviewed changes

hugorut added 4 commits March 16, 2022 16:44

fix: comment-action uses infracost-comment

7951b61

fix: change text to option and fix spacing

a1eaafb

fix: naming

85e06f9

fix: switch comment behavior to new

6325712

hugorut force-pushed the fix/comment-actions branch from 466dd8e to 6325712 Compare March 16, 2022 16:44

hugorut merged commit bc9002a into master Mar 16, 2022

hugorut deleted the fix/comment-actions branch March 16, 2022 16:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/comment actions #57

Fix/comment actions #57

hugorut commented Mar 11, 2022 •

edited

Loading

github-actions bot commented Mar 11, 2022

github-actions bot commented Mar 11, 2022

github-actions bot commented Mar 11, 2022

github-actions bot commented Mar 15, 2022

github-actions bot commented Mar 15, 2022

vdmgolub left a comment

github-actions bot commented Mar 16, 2022

github-actions bot commented Mar 16, 2022

Fix/comment actions #57

Fix/comment actions #57

Conversation

hugorut commented Mar 11, 2022 • edited Loading

github-actions bot commented Mar 11, 2022

github-actions bot commented Mar 11, 2022

github-actions bot commented Mar 11, 2022

github-actions bot commented Mar 15, 2022

github-actions bot commented Mar 15, 2022

vdmgolub left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 16, 2022

github-actions bot commented Mar 16, 2022

hugorut commented Mar 11, 2022 •

edited

Loading