Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3 compatibility #15

Merged
merged 1 commit into from
Feb 17, 2016
Merged

python3 compatibility #15

merged 1 commit into from
Feb 17, 2016

Conversation

tkurze
Copy link

@tkurze tkurze commented Jan 26, 2016

Hi,

I changed a few imports and exception handling to achieve Python3 compatibility.
I tested quickly against a local library repository and encountered no problems. I didn't ran any further tests though.

@jascoul
Copy link
Collaborator

jascoul commented Jan 27, 2016

Hi Tobias,

Thanks, that's awesome, looks great.
I'll try to run some tests this week and then merge and do a pypi release

@tkurze
Copy link
Author

tkurze commented Jan 27, 2016

Hi Jasper,

no problem. Glad I could help :)

On 01/27/2016 10:38 AM, Jasper Op de Coul wrote:

Hi Tobias,

Thanks, that's awesome, looks great.
I'll try to run some tests this week and then merge and do a pypi release


Reply to this email directly or view it on GitHub
#15 (comment).

@jascoul jascoul merged commit 7351069 into infrae:master Feb 17, 2016
@jascoul
Copy link
Collaborator

jascoul commented Feb 17, 2016

Hi,

I just merged your patch.
I changed the code a bit to remove the six dependency, and some other minor issues.
Can you test if this works for you on python3?
I will do a pypi release soon.

@tkurze
Copy link
Author

tkurze commented Feb 17, 2016

Hi,

OK. Cool.

I just ran my snippets with your code and everything seems fine to me 👍

On 02/17/2016 12:19 PM, Jasper Op de Coul wrote:

Hi,

I just merged your patch.
I changed the code a bit to remove the six dependency, and some other
minor issues.
Can you test if this works for you on python3?
I will do a pypi release soon.


Reply to this email directly or view it on GitHub
#15 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants