Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate permissions #62

Merged
merged 9 commits into from
Sep 20, 2023
Merged

Integrate permissions #62

merged 9 commits into from
Sep 20, 2023

Conversation

rizzza
Copy link
Contributor

@rizzza rizzza commented Sep 18, 2023 •
edited
Loading

Summary

Wire up new permissions checks for the annotation/status namespaces

  • Fix 🐛 ensuring we cannot set an empty resourceProviderID for a status namespace
  • Add in events and other boilerplate for the test db setup; wire up the ent hooks
  • Mock permissions in all the resolver unit tests
  • Add oidc auth test to verify access with and without oidc enabled
  • Add unit test for status namespace

Issue found with event hooks and deleting multiple things from the db in one shot. Worked around it by deleting one record at a time.

@rizzza
oidc auth test
47f81c2 
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
@rizzza
get annotation namespace
6f071cc 
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
@rizzza
save progress
faf0b1d 
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Sep 18, 2023 •
edited
Loading

GraphQL Schema Check

Compared 0 schema changes against null operations

✅ Found no changes

🔗 View full schema check details

@rizzza
integrate permissions
66c8015 
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
@rizzza
update statusnamespace schema to verify a non-empty resource-provider…
06b624d 
…-id; unit tests

Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
@rizzza
gitattributes to unmark resolvers for render in pr
929d906 
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
@rizzza rizzza marked this pull request as ready for review September 19, 2023 17:49
@rizzza rizzza requested review from a team as code owners September 19, 2023 17:49
@rizzza
unit test
b6ffdd8 
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
@rizzza
simplify permissions to just namespace crud
035f641 
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
@rizzza
remove old comment
9ad7127 
Signed-off-by: Matt Siwiec <rizzza@users.noreply.github.com>
nicolerenee
nicolerenee approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@nicolerenee nicolerenee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for the initial pass.

@rizzza rizzza merged commit 4ef6f95 into infratographer:main Sep 20, 2023
@rizzza rizzza deleted the permissions branch September 20, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolerenee nicolerenee nicolerenee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rizzza @nicolerenee