Add missing fields (#295)

* add missing manager field in response Signed-off-by: Mike Mason <mimason@equinix.com> * validate that action and type names are configured Signed-off-by: Mike Mason <mimason@equinix.com> --------- Signed-off-by: Mike Mason <mimason@equinix.com>
infratographer · Oct 24, 2024 · 169ee48 · 169ee48
1 parent 5ea2cd5
commit 169ee48
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/internal/iapl/policy.go b/internal/iapl/policy.go
@@ -388,6 +388,14 @@ func (v *policy) validateActionBindings() error {
 	bindingMap := make(map[bindingMapKey]struct{}, len(v.p.ActionBindings))
 
 	for i, binding := range v.bn {
+		if binding.ActionName == "" {
+			return fmt.Errorf("%d (%s:%s): %w", i, binding.TypeName, binding.ActionName, ErrorUnknownAction)
+		}
+
+		if binding.TypeName == "" {
+			return fmt.Errorf("%d (%s:%s): %w", i, binding.TypeName, binding.ActionName, ErrorUnknownType)
+		}
+
 		key := bindingMapKey{
 			actionName: binding.ActionName,
 			typeName:   binding.TypeName,

diff --git a/internal/query/roles_v2.go b/internal/query/roles_v2.go
@@ -83,6 +83,7 @@ func (e *engine) CreateRoleV2(ctx context.Context, actor, owner types.Resource,
 		return types.Role{}, err
 	}
 
+	role.Manager = dbRole.Manager
 	role.CreatedBy = dbRole.CreatedBy
 	role.UpdatedBy = dbRole.UpdatedBy
 	role.ResourceID = dbRole.ResourceID