ENG-22892 fix: UnmarshalRawMessage of a gql quoted string #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Bielecki <47531708+jabielecki@users.noreply.github.com>
Bug with a GQL schema: `json: JSON!`
and with the input `json: "json quotes strings"`
Output is wrong: json.RawMessage("json quotes strings")
For example this always fails:
```
var res any
json.Unmarshal(json.RawMessage("json quotes strings"), &res)
```
Correcting to: json.RawMessage("\"json quotes strings\"")
Signed-off-by: Jakub Bielecki <47531708+jabielecki@users.noreply.github.com>
Signed-off-by: Jakub Bielecki <47531708+jabielecki@users.noreply.github.com>
jabielecki
force-pushed
the
jab/json_string
branch
from
fa35dc9 to
c67620c
Compare
jabielecki
changed the title
nicolerenee
approved these changes
Sep 28, 2023
|
For some additional testing I pulled this branch into a local copy of load-balancer-api and ran through the tests and everything was still passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Fix idea suggested by @jarrodb)
Bug with this GQL schema:
json: JSON!and with the input
json: "json quotes strings"Output is wrong:
json.RawMessage("json quotes strings")For example this always fails:
Correcting to:
json.RawMessage("\"json quotes strings\"")