Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OperatorHub.io as a CatalogSource #394

Merged
merged 3 commits into from
Nov 24, 2022

Conversation

leifmadsen
Copy link
Member

Remove the OperatorHub.io CatalogSource and instead use the
community-operators CatalogSource which is available with an OCP
installation. Ideally this will avoid some of the conflicts we've been
seeing in our CI environment. This is a short term fix as future
development will likely make use of Observability Operator to provide
the metrics data store and alert delivery mechanism.

Remove the OperatorHub.io CatalogSource and instead use the
community-operators CatalogSource which is available with an OCP
installation. Ideally this will avoid some of the conflicts we've been
seeing in our CI environment. This is a short term fix as future
development will likely make use of Observability Operator to provide
the metrics data store and alert delivery mechanism.
@leifmadsen
Copy link
Member Author

test

@leifmadsen
Copy link
Member Author

...
TASK [stf-run-ci : Remove OperatorHub.io CatalogSource if it installed] ********
changed: [localhost]
...

Looks like the old OperatorHub.io CatalogSource was removed. The job passed as well (not sure if this helped anything though).

@leifmadsen
Copy link
Member Author

test

@leifmadsen leifmadsen marked this pull request as ready for review November 22, 2022 21:01
@leifmadsen leifmadsen merged commit e50f057 into master Nov 24, 2022
@leifmadsen leifmadsen deleted the remove-operatorhubio-catalogsource branch November 24, 2022 21:22
leifmadsen added a commit that referenced this pull request Feb 9, 2023
Remove the OperatorHub.io CatalogSource and instead use the
community-operators CatalogSource which is available with an OCP
installation. Ideally this will avoid some of the conflicts we've been
seeing in our CI environment. This is a short term fix as future
development will likely make use of Observability Operator to provide
the metrics data store and alert delivery mechanism.

(cherry-picked from commit e50f057)

Backporting this change in order to help with environment cleanup in
testing to avoid some timeouts we're seeing related to this
CatalogSource.
csibbitt added a commit that referenced this pull request Mar 7, 2023
* Fixes for 17.0 ir script (#380)

* Move the SNMP trap delivery checks (#381)

* Move the SNMP trap delivery checks

Move the SNMP trap delivery checks as where they are situated now seems
to cause false positives. Moves the checks closer to the end of the
smoketest run seems to result in a better change that the logs the check
is looking for have been provided.

* Use a loop to check for SNMP status with break and max time

* Lock the bundle to OCP v4.10 (#385)

* Make all certs 8yr expiry

* Revert "Make all certs 8yr expiry"

This reverts commit af35714.

* Make all certs 8yr expiry (#387)

* Make all certs 8yr expiry
* Use certificate_duration and test against generated cert
* Better messages during CI cloning

* Expand support for OCP 4.11 (#391)

* Expand support for OCP 4.11

Allow installation to be done on OCP 4.11 while updating the smoketest
jobs to support later versions of the client. Also migrate to using
community-operators CatalogSource instead of OperatorHub.io. Only enable
community-operators when the use_community strategy is enabled.

Update the token request syntax when requesting a service account token.
Add checks to look for oc client version and fail if we're using a
version that's too old.

* Make passwords safer in smoketest job template

Encapsulate the password values with double quotes to help make them
safer for consumption in the template. I had an odd situation where the
password contained a bunch of extended characters and caused the
smoketest to report an error on the template having an issue with yaml
to json.

The password contained several characters such as . and : which confused
the template. Wrapping the contents in the double quotes allowed the
smoketest to apply the job.batch template and result in a working
smoketest run.

* Force SGO checkout during build (#388)

* Replacing the placeholder namespace during the build results in a "there are local changes" error on next build
* This forces the checkout to discard that (and other!?) local changes
* Quicker dev/test loop

* Update oc to 4.11 in jenkins agent (#393)

* Update oc to 4.11 in jenkins agent

Need 4.11 for new token handling changes

* Remove OperatorHub.io as a CatalogSource (#394)

Remove the OperatorHub.io CatalogSource and instead use the
community-operators CatalogSource which is available with an OCP
installation. Ideally this will avoid some of the conflicts we've been
seeing in our CI environment. This is a short term fix as future
development will likely make use of Observability Operator to provide
the metrics data store and alert delivery mechanism.

* Changes for 4.12 (#401)

* Catalog changes
* CI change to pre-clean cert-manager-operator
  * not 100% sure this is 4.12 related, but it's new and first seen during testing 4.12

* Remove Loki from stf-run-ci (#405)

* Remove Loki from stf-run-ci

* Return "Get new operator sdk" to stf-run-ci

* GHA checkout action v2 is deprecated (#407)

The GitHub Actions checkout action v2 is deprecated and needs to move to
version 3.

* Implement SNMPtrap delivery controls (#404)

* Implement SNMPtrap delivery controls

Implement ability to override the default values for the SNMPtrap
alertmanager receiver via prometheus-webhook-snmp component.

Closes: STF-559

* Run operator-sdk generate bundle

Run the following command to update the bundle artifacts:

operator-sdk-0.19.4 generate bundle   --metadata   --manifests   --channels unstable   --default-channel unstable

* Build out the remaining SNMP options

Build out the remaining options for prometheus-webhook-snmp to allow for
finer grained controls and delivery of SNMP traps via alertmanager
alerts.

* Generate bundle contents with operator-sdk

* Implement changes for operator-sdk-1.26.0 testing (#411)

* Implement changes for operator-sdk-1.26.0 testing

Implement changes that allow testing validation via operator-sdk-1.26.0
without bumping the entire bundle generation process from
operator-sdk-0.19.4 to post-operator-sdk-1.x.

These are the same tests run for validation during product pipeline
verification.

* Adds test to verify building of the bundle image works.
* Adds KinD deployment to allow executing scorecard checks.

Related: STF-1252

* Fix properties.yaml

* Simplify use of RELEASE_VERSION variable (#412)

* Add note about why we're copying files in

* Expose ability to set certificate renewal target times (#406)

* Adds duration param for CA and endpoint certs

Replaces certificate_duration for ca_certificate_duration
and endpoint_certificate_duration. Set default value for those
to 70080h (previous value)

Removes the certificate_duration param from the Issuer
resource since it's not actually needed (see [0])

[0] https://cert-manager.io/docs/reference/api-docs/#cert-manager.io/v1.IssuerConfig

* Exposes CA and endpoint certificate duration config

Exposes certificate duration config for both ElasticSearch
and QDR

Keeps the default value in use for now. Better default values
should be discussed to be included in a follow up change.

* Fix identation for certs duration param in servicetelemetry crd

* Adds cert duration to the OLM catalog

Includes cert duration params in the OLM catalog
for both ElasticSearch and QDR

* Changes snake_case to camelCase to yaml case

Fix to match style convention

* Adds pattern expresion for certs duration

* Add certificates param to events and transport

* Exposes duration parameter in the CI script

Adds the duration parameter for both ElasticSearch and QDR
in the CI script

Also updates the OLM Catalog with the latest changes (certificates object)

* Corrects naming to certificates params in CI script

* Fix snake cae in the CI script params for cert duration

* Fix identation for transports in the deploy_stf CI script

---------

Co-authored-by: Chris Sibbitt <csibbitt@redhat.com>

---------

Co-authored-by: Leif Madsen <lmadsen@redhat.com>
Co-authored-by: Jaromír Wysoglad <jwysogla@redhat.com>
Co-authored-by: Victoria Martinez de la Cruz <victoria@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants