Use the proper parameter for SNMP timeout #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SNMP_TIMEOUT environment variable in the manifest_snmp_traps.j2 template for Service Telemetry Operator uses the wrong parameter, passing port instead of timeout value to the template. This change updates the template to use the appropriate parameter as input. Closes: rhbz#2213016
|
I haven't tested this yet. I made this change based on looking at the contents when I was looking at something else to close out an issue. Oops! |
|
/test |
csibbitt
approved these changes
Jun 12, 2023
|
test |
|
I should probably do a real test here before merging to make sure I have all the proper parameters aligned and that changing the CR results in what I expect. I have that on my list for this sprint and should be able to get this merged soon. Thanks for the review! |
|
I was testing spin up of OCP on PSI and it resulted in a working cluster. I deployed this branch against that cluster and performed some verification.
This issue is verified. I will merge it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SNMP_TIMEOUT environment variable in the manifest_snmp_traps.j2
template for Service Telemetry Operator uses the wrong parameter,
passing port instead of timeout value to the template.
This change updates the template to use the appropriate parameter as
input.
Closes: rhbz#2213016