Add lint testing for stf-run-ci fqcn #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/infrawatch/service-telemetry-operator/actions/runs/6186325878/job/16793691461 << shows a job that fails when fqcn is not met (verified) |
csibbitt
approved these changes
Sep 14, 2023
| @@ -0,0 +1,52 @@ | |||
| --- | |||
| profile: null | |||
| skip_list: | |||
There was a problem hiding this comment.
Lol. Are we currently in such a bad shape that we fail all of these?!
There was a problem hiding this comment.
I just wanted to keep the scope incredibly small and focused on fqcn. There were about 57 total issues if I remember correctly. Nothing too crazy, but I got this list by doing ansible-lint -L | cut -f3 -d' ' and then adding them to the list, and removing fqcn. It then complained about 2 more non-optional items, and those ones also pass :)
After we get through all of this I'd like to remove the list and start fixing anything it finds. It's not that bad, but didn't want to over scope :)
There was a problem hiding this comment.
We don't fail all of these, these are all the rules that are checked
|
Also FWIW :) Rule Violation Summary
count tag profile rule associated tags
1 command-instead-of-module basic command-shell, idiom
5 command-instead-of-shell basic command-shell, idiom
2 key-order[task] basic formatting
2 jinja[spacing] basic formatting (warning)
18 name[missing] basic idiom
7 yaml[braces] basic formatting, yaml
1 yaml[empty-lines] basic formatting, yaml
3 yaml[new-line-at-end-of-file] basic formatting, yaml
4 name[template] moderate idiom
2 risky-file-permissions safety unpredictability
2 risky-shell-pipe safety command-shell
1 ignore-errors shared unpredictability
22 no-changed-when shared command-shell, idempotency
Failed: 68 failure(s), 2 warning(s) on 23 files. Last profile that met the validation criteria was 'min'.[
{
"type": "issue",
"check_name": "yaml[new-line-at-end-of-file]",
"categories": [
"formatting",
"yaml"
],
"url": "https://ansible-lint.readthedocs.io/rules/yaml/",
"severity": "major",
"description": "No new line character at the end of file",
"fingerprint": "6d06f50eb4a8b1f627052211b54b16a0350694c113ee53e68c06fcb860726a99",
"location": {
"path": "build/stf-run-ci/handlers/main.yml",
"lines": {
"begin": 2
}
}
},
{
"type": "issue",
"check_name": "name[template]",
"categories": [
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/name/",
"severity": "major",
"description": "Jinja templates should only be at the end of 'name'",
"fingerprint": "32e62b004c1d33bea68ea9521e7a8ade100e2f496a590409df3741ae5517f379",
"location": {
"path": "build/stf-run-ci/tasks/clone_repos.yml",
"lines": {
"begin": 15
}
},
"content": {
"body": "Task/Handler: Get {{ version_branches.sgo }} upstream branch because specified branch or repository doesn't exist"
}
},
{
"type": "issue",
"check_name": "name[template]",
"categories": [
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/name/",
"severity": "major",
"description": "Jinja templates should only be at the end of 'name'",
"fingerprint": "f42c8d9770bab5abb02101cbfea96629c650850673cada4a6103f7ec3f2a9cc9",
"location": {
"path": "build/stf-run-ci/tasks/clone_repos.yml",
"lines": {
"begin": 29
}
},
"content": {
"body": "Task/Handler: Get {{ version_branches.sg_core }} upstream branch because specified branch or repository doesn't exist"
}
},
{
"type": "issue",
"check_name": "name[template]",
"categories": [
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/name/",
"severity": "major",
"description": "Jinja templates should only be at the end of 'name'",
"fingerprint": "320aeb88f282f6d46ebdce859e9f116e0c512fc6e31615c3e48a706c7485a8b9",
"location": {
"path": "build/stf-run-ci/tasks/clone_repos.yml",
"lines": {
"begin": 43
}
},
"content": {
"body": "Task/Handler: Get {{ version_branches.sg_bridge }} upstream branch because specified branch or repository doesn't exist"
}
},
{
"type": "issue",
"check_name": "name[template]",
"categories": [
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/name/",
"severity": "major",
"description": "Jinja templates should only be at the end of 'name'",
"fingerprint": "63557a263827bea15824527d2990c9315f0328f106e8181ac4ab58a10e876aab",
"location": {
"path": "build/stf-run-ci/tasks/clone_repos.yml",
"lines": {
"begin": 57
}
},
"content": {
"body": "Task/Handler: Get {{ version_branches.prometheus_webhook_snmp }} upstream branch because specified branch or repository doesn't exist"
}
},
{
"type": "issue",
"check_name": "yaml[empty-lines]",
"categories": [
"formatting",
"yaml"
],
"url": "https://ansible-lint.readthedocs.io/rules/yaml/",
"severity": "major",
"description": "Too many blank lines (1 > 0)",
"fingerprint": "7119540aaae451d216b6c0a71ac05705116d2ea5c3b3164c0e2a17f23f8050a3",
"location": {
"path": "build/stf-run-ci/tasks/clone_repos.yml",
"lines": {
"begin": 62
}
}
},
{
"type": "issue",
"check_name": "name[missing]",
"categories": [
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/name/",
"severity": "major",
"description": "All tasks should be named.",
"fingerprint": "951729ed40e5e8d143c66d0e050c33428f5d114dc876df0191d7c2b40aabaed6",
"location": {
"path": "build/stf-run-ci/tasks/create_builds.yml",
"lines": {
"begin": 19
}
},
"content": {
"body": "Task/Handler: block/always/rescue "
}
},
{
"type": "issue",
"check_name": "no-changed-when",
"categories": [
"command-shell",
"idempotency"
],
"url": "https://ansible-lint.readthedocs.io/rules/no-changed-when/",
"severity": "major",
"description": "Commands should not change things if nothing needs doing.",
"fingerprint": "d50c85888f6ac9a01efdadece64e7945d4b48bb65460983caffdb0ef7f1deb93",
"location": {
"path": "build/stf-run-ci/tasks/create_builds.yml",
"lines": {
"begin": 21
}
},
"content": {
"body": "Task/Handler: Create BuildConfig and ImageStream"
}
},
{
"type": "issue",
"check_name": "no-changed-when",
"categories": [
"command-shell",
"idempotency"
],
"url": "https://ansible-lint.readthedocs.io/rules/no-changed-when/",
"severity": "major",
"description": "Commands should not change things if nothing needs doing.",
"fingerprint": "ff7a0a5eb04c6ee9630f0b1e702ce5862d038ead440e5ce17033fc764726a228",
"location": {
"path": "build/stf-run-ci/tasks/create_builds.yml",
"lines": {
"begin": 24
}
},
"content": {
"body": "Task/Handler: Kill first build since it will always fail (triggered on BuildConfig creation)"
}
},
{
"type": "issue",
"check_name": "no-changed-when",
"categories": [
"command-shell",
"idempotency"
],
"url": "https://ansible-lint.readthedocs.io/rules/no-changed-when/",
"severity": "major",
"description": "Commands should not change things if nothing needs doing.",
"fingerprint": "388584228c5697187a33a2ac79ba4897ed6ca4590b0c5a43dcbf58df90909961",
"location": {
"path": "build/stf-run-ci/tasks/create_builds.yml",
"lines": {
"begin": 27
}
},
"content": {
"body": "Task/Handler: Start local image build"
}
},
{
"type": "issue",
"check_name": "no-changed-when",
"categories": [
"command-shell",
"idempotency"
],
"url": "https://ansible-lint.readthedocs.io/rules/no-changed-when/",
"severity": "major",
"description": "Commands should not change things if nothing needs doing.",
"fingerprint": "6bf13265e1a2afe06c6945814d0de0313273904a15ab8dabbe618be8a26f20e5",
"location": {
"path": "build/stf-run-ci/tasks/create_builds.yml",
"lines": {
"begin": 32
}
},
"content": {
"body": "Task/Handler: Get latest build information for artifact"
}
},
{
"type": "issue",
"check_name": "name[missing]",
"categories": [
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/name/",
"severity": "major",
"description": "All tasks should be named.",
"fingerprint": "6423fd18a8d2a06a6d89ff2f53ce39098696053deef5f93e78576e73beae5ed4",
"location": {
"path": "build/stf-run-ci/tasks/create_builds.yml",
"lines": {
"begin": 40
}
},
"content": {
"body": "Task/Handler: debug var=build_describe"
}
},
{
"type": "issue",
"check_name": "name[missing]",
"categories": [
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/name/",
"severity": "major",
"description": "All tasks should be named.",
"fingerprint": "d0b211f3ddaaecdbb8457be2f4d936d1fdc868a0db858dba2b1f2578b346bd5a",
"location": {
"path": "build/stf-run-ci/tasks/create_builds.yml",
"lines": {
"begin": 43
}
},
"content": {
"body": "Task/Handler: debug var=build_describe.status.outputDockerImageReference"
}
},
{
"type": "issue",
"check_name": "no-changed-when",
"categories": [
"command-shell",
"idempotency"
],
"url": "https://ansible-lint.readthedocs.io/rules/no-changed-when/",
"severity": "major",
"description": "Commands should not change things if nothing needs doing.",
"fingerprint": "d0ae7ac5833d9f65d8410a073b65d32dab7a89873621043bd2742d4430a08d65",
"location": {
"path": "build/stf-run-ci/tasks/create_catalog.yml",
"lines": {
"begin": 13
}
},
"content": {
"body": "Task/Handler: Get the builder-dockercfg Secret name"
}
},
{
"type": "issue",
"check_name": "name[missing]",
"categories": [
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/name/",
"severity": "major",
"description": "All tasks should be named.",
"fingerprint": "66f6e4c7ae15a4a4078d7c75d35c82e519124f6328231ad80ee376fa0817c842",
"location": {
"path": "build/stf-run-ci/tasks/create_catalog.yml",
"lines": {
"begin": 33
}
},
"content": {
"body": "Task/Handler: block/always/rescue "
}
},
{
"type": "issue",
"check_name": "risky-file-permissions",
"categories": [
"unpredictability"
],
"url": "https://ansible-lint.readthedocs.io/rules/risky-file-permissions/",
"severity": "major",
"description": "File permissions unset or incorrect.",
"fingerprint": "e1393a6ea83f707e67865f052aaa9f7777cbaee76b5aa6a36d719b862fe946d3",
"location": {
"path": "build/stf-run-ci/tasks/create_catalog.yml",
"lines": {
"begin": 35
}
},
Read documentation for instructions on how to ignore specific rule violations.
"content": {
"body": "Task/Handler: Create config.json to import as Secret"
}
},
{
"type": "issue",
"check_name": "no-changed-when",
"categories": [
"command-shell",
"idempotency"
],
"url": "https://ansible-lint.readthedocs.io/rules/no-changed-when/",
"severity": "major",
"description": "Commands should not change things if nothing needs doing.",
"fingerprint": "4b260e765bd22aaf0a9530c48908cad6937eaef120f0488ab523fbd38c795418",
"location": {
"path": "build/stf-run-ci/tasks/create_catalog.yml",
"lines": {
"begin": 42
}
},
"content": {
"body": "Task/Handler: Create a Secret for the dockercfg"
}
},
{
"type": "issue",
"check_name": "no-changed-when",
"categories": [
"command-shell",
"idempotency"
],
"url": "https://ansible-lint.readthedocs.io/rules/no-changed-when/",
"severity": "major",
"description": "Commands should not change things if nothing needs doing.",
"fingerprint": "7f9a51156df15e18f4005e8e1dafaaa0249faa134e5a3a99830a9e2e919715d3",
"location": {
"path": "build/stf-run-ci/tasks/create_catalog.yml",
"lines": {
"begin": 45
}
},
"content": {
"body": "Task/Handler: Create ImageStream for ose-operator-registry"
}
},
{
"type": "issue",
"check_name": "no-changed-when",
"categories": [
"command-shell",
"idempotency"
],
"url": "https://ansible-lint.readthedocs.io/rules/no-changed-when/",
"severity": "major",
"description": "Commands should not change things if nothing needs doing.",
"fingerprint": "f6fe84887cd862352115f69cfb34109aed8237e43480d1b4e82c3f8d37fc3baf",
"location": {
"path": "build/stf-run-ci/tasks/create_catalog.yml",
"lines": {
"begin": 49
}
},
"content": {
"body": "Task/Handler: Create ImageStream for service-telemetry-framework-index"
}
},
{
"type": "issue",
"check_name": "name[missing]",
"categories": [
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/name/",
"severity": "major",
"description": "All tasks should be named.",
"fingerprint": "31552b71264d7d3a1b0912582e4ea6f934082098d2c4e723dd77bcecd0fb706f",
"location": {
"path": "build/stf-run-ci/tasks/create_catalog.yml",
"lines": {
"begin": 120
}
},
"content": {
"body": "Task/Handler: block/always/rescue "
}
},
{
"type": "issue",
"check_name": "risky-file-permissions",
"categories": [
"unpredictability"
],
"url": "https://ansible-lint.readthedocs.io/rules/risky-file-permissions/",
"severity": "major",
"description": "File permissions unset or incorrect.",
"fingerprint": "c74fbef1a7b2e7d356e0790620fab25f6d9a781cb4cec5d7df437a19303845cc",
"location": {
"path": "build/stf-run-ci/tasks/create_catalog.yml",
"lines": {
"begin": 122
}
},
"content": {
"body": "Task/Handler: Create index.yaml base for index image"
}
},
{
"type": "issue",
"check_name": "no-changed-when",
"categories": [
"command-shell",
"idempotency"
],
"url": "https://ansible-lint.readthedocs.io/rules/no-changed-when/",
"severity": "major",
"description": "Commands should not change things if nothing needs doing.",
"fingerprint": "a7b89d6f4b8e56e063c4257ba95a9c183ca50b264bcd8b9df109863d81d9297c",
"location": {
"path": "build/stf-run-ci/tasks/create_catalog.yml",
"lines": {
"begin": 127
}
},
"content": {
"body": "Task/Handler: Build service-telemetry-framework-index"
}
},
{
"type": "issue",
"check_name": "no-changed-when",
"categories": [
"command-shell",
"idempotency"
],
"url": "https://ansible-lint.readthedocs.io/rules/no-changed-when/",
"severity": "major",
"description": "Commands should not change things if nothing needs doing.",
"fingerprint": "4778303dd1ded114d2f8715fdeb1a06aa4df51e93dc8b4f93c350581ab847605",
"location": {
"path": "build/stf-run-ci/tasks/main.yml",
"lines": {
"begin": 44
}
},
"content": {
"body": "Task/Handler: Get OCP version"
}
},
{
"type": "issue",
"check_name": "risky-shell-pipe",
"categories": [
"command-shell"
],
"url": "https://ansible-lint.readthedocs.io/rules/risky-shell-pipe/",
"severity": "major",
"description": "Shells that use pipes should set the pipefail option.",
"fingerprint": "3d864c1a470a57c081fcfc91e800827f4728f35dcaf43a9c1b1fdc3faa92f73e",
"location": {
"path": "build/stf-run-ci/tasks/main.yml",
"lines": {
"begin": 44
}
},
"content": {
"body": "Task/Handler: Get OCP version"
}
},
{
"type": "issue",
"check_name": "no-changed-when",
"categories": [
"command-shell",
"idempotency"
],
"url": "https://ansible-lint.readthedocs.io/rules/no-changed-when/",
"severity": "major",
"description": "Commands should not change things if nothing needs doing.",
"fingerprint": "fddaeeaa01fb31be98dbc33de96c25c43a930e2fde45fef9b2b050002d9b3324",
"location": {
"path": "build/stf-run-ci/tasks/main.yml",
"lines": {
"begin": 71
}
},
"content": {
"body": "Task/Handler: Get new operator sdk"
}
},
{
"type": "issue",
"check_name": "name[missing]",
"categories": [
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/name/",
"severity": "major",
"description": "All tasks should be named.",
"fingerprint": "15b3b8edaec826cfaaecf5fc276689a9fdec231f73024347202884db4f983e01",
"location": {
"path": "build/stf-run-ci/tasks/main.yml",
"lines": {
"begin": 76
}
},
"content": {
"body": "Task/Handler: block/always/rescue "
}
},
{
"type": "issue",
"check_name": "yaml[braces]",
"categories": [
"formatting",
"yaml"
],
"url": "https://ansible-lint.readthedocs.io/rules/yaml/",
"severity": "major",
"description": "Too many spaces inside braces",
"fingerprint": "b0387364de1c62952d30d34bd25fa072d7514d35ac25fc6808c21dcabe87a789",
"location": {
"path": "build/stf-run-ci/tasks/main.yml",
"lines": {
"begin": 88
}
}
},
{
"type": "issue",
"check_name": "yaml[braces]",
"categories": [
"formatting",
"yaml"
],
"url": "https://ansible-lint.readthedocs.io/rules/yaml/",
"severity": "major",
"description": "Too many spaces inside braces",
"fingerprint": "7703d2da87df06fcdbfa1d7c785dfe960eff3e9a5b2313f8ae70d34bad23bbd2",
"location": {
"path": "build/stf-run-ci/tasks/main.yml",
"lines": {
"begin": 89
}
}
},
{
"type": "issue",
"check_name": "yaml[braces]",
"categories": [
"formatting",
"yaml"
],
"url": "https://ansible-lint.readthedocs.io/rules/yaml/",
"severity": "major",
"description": "Too many spaces inside braces",
"fingerprint": "ec6ff4149612db959395810afaba55fd948b9d97c384ad19748434bee071af86",
"location": {
"path": "build/stf-run-ci/tasks/main.yml",
"lines": {
"begin": 90
}
}
},
{
"type": "issue",
"check_name": "yaml[braces]",
"categories": [
"formatting",
"yaml"
],
"url": "https://ansible-lint.readthedocs.io/rules/yaml/",
"severity": "major",
"description": "Too many spaces inside braces",
"fingerprint": "2bfffbb469765a0871f2b95449a29feafe4faabadbb93e499a49f388b9ee1956",
"location": {
"path": "build/stf-run-ci/tasks/main.yml",
"lines": {
"begin": 91
}
}
},
{
"type": "issue",
"check_name": "yaml[braces]",
"categories": [
"formatting",
"yaml"
],
"url": "https://ansible-lint.readthedocs.io/rules/yaml/",
"severity": "major",
"description": "Too many spaces inside braces",
"fingerprint": "3e7505617bf52a3b9155887d036388335c6cbc2f77eedf8740964e5b9857bd2c",
"location": {
"path": "build/stf-run-ci/tasks/main.yml",
"lines": {
"begin": 92
}
}
},
{
"type": "issue",
"check_name": "name[missing]",
"categories": [
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/name/",
"severity": "major",
"description": "All tasks should be named.",
"fingerprint": "5b4f38b2ad21dffc495bb2d4c65173de33eeb7a5fbc0647570b0b8376ceb0f0e",
"location": {
"path": "build/stf-run-ci/tasks/main.yml",
"lines": {
"begin": 94
}
},
"content": {
"body": "Task/Handler: debug var=build_list"
}
},
{
"type": "issue",
"check_name": "name[missing]",
"categories": [
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/name/",
"severity": "major",
"description": "All tasks should be named.",
"fingerprint": "d629dc96dbb795432eb4de738bb289a9bcac2bd45df4ab5be504a3f6b67bfb34",
"location": {
"path": "build/stf-run-ci/tasks/main.yml",
"lines": {
"begin": 110
}
},
"content": {
"body": "Task/Handler: block/always/rescue "
}
},
{
"type": "issue",
"check_name": "yaml[braces]",
"categories": [
"formatting",
"yaml"
],
"url": "https://ansible-lint.readthedocs.io/rules/yaml/",
"severity": "major",
"description": "Too many spaces inside braces",
"fingerprint": "12764bdd886b339cfa436396ffa5f13b1d508faee91f8d6a98c21c4b861d50c8",
"location": {
"path": "build/stf-run-ci/tasks/main.yml",
"lines": {
"begin": 117
}
}
},
{
"type": "issue",
"check_name": "yaml[braces]",
"categories": [
"formatting",
"yaml"
],
"url": "https://ansible-lint.readthedocs.io/rules/yaml/",
"severity": "major",
"description": "Too many spaces inside braces",
"fingerprint": "f2c496e073b8f97b505a97be8336d1e559bd54a4081150520bf7b0795c0494cb",
"location": {
"path": "build/stf-run-ci/tasks/main.yml",
"lines": {
"begin": 118
}
}
},
{
"type": "issue",
"check_name": "name[missing]",
"categories": [
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/name/",
"severity": "major",
"description": "All tasks should be named.",
"fingerprint": "df509ba2fc2ec8f4a2584704ac736c82fbdeb2f57cc2ad52a116a0cca9cb28bc",
"location": {
"path": "build/stf-run-ci/tasks/main.yml",
"lines": {
"begin": 120
}
},
"content": {
"body": "Task/Handler: debug var=bundle_build_list"
}
},
{
"type": "issue",
"check_name": "name[missing]",
"categories": [
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/name/",
"severity": "major",
"description": "All tasks should be named.",
"fingerprint": "980a3130b3f3798bdb1741a550a1c20908f4ca5be8eed128609963365377c204",
"location": {
"path": "build/stf-run-ci/tasks/main.yml",
"lines": {
"begin": 135
}
},
"content": {
"body": "Task/Handler: block/always/rescue "
}
},
{
"type": "issue",
"check_name": "key-order[task]",
"categories": [
"formatting"
],
"url": "https://ansible-lint.readthedocs.io/rules/key-order/",
"severity": "major",
"description": "You can improve the task key order to: name, when, kubernetes.core.k8s",
"fingerprint": "61de003f031af490e1e18d990b6856d2c1a0bb97ddba20a909ff763c78366051",
"location": {
"path": "build/stf-run-ci/tasks/main.yml",
"lines": {
"begin": 145
}
},
"content": {
"body": "Task/Handler: Subscribe to locally built Service Telemetry Operator"
}
},
{
"type": "issue",
"check_name": "name[missing]",
"categories": [
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/name/",
"severity": "major",
"description": "All tasks should be named.",
"fingerprint": "25d703ed07f3450252ebaf3160c1e76908e2c34fb9d281d9c70c58bcac448f15",
"location": {
"path": "build/stf-run-ci/tasks/main.yml",
"lines": {
"begin": 168
}
},
"content": {
"body": "Task/Handler: block/always/rescue "
}
},
{
"type": "issue",
"check_name": "no-changed-when",
"categories": [
"command-shell",
"idempotency"
],
"url": "https://ansible-lint.readthedocs.io/rules/no-changed-when/",
"severity": "major",
"description": "Commands should not change things if nothing needs doing.",
"fingerprint": "e33e243614cf740c0458d0dfb3f8ed2b71c2f2e4b2088adba9de05c85561285a",
"location": {
"path": "build/stf-run-ci/tasks/main.yml",
"lines": {
"begin": 173
}
},
"content": {
"body": "Task/Handler: Validate system is operational"
}
},
{
"type": "issue",
"check_name": "name[missing]",
"categories": [
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/name/",
"severity": "major",
"description": "All tasks should be named.",
"fingerprint": "b04036c3c5430c037b01ee75410fa2a3ad796715589c3551c0b20d369a0499ec",
"location": {
"path": "build/stf-run-ci/tasks/main.yml",
"lines": {
"begin": 180
}
},
"content": {
"body": "Task/Handler: debug var=validate_deployment.stdout_lines"
}
},
{
"type": "issue",
"check_name": "ignore-errors",
"categories": [
"unpredictability"
],
"url": "https://ansible-lint.readthedocs.io/rules/ignore-errors/",
"severity": "major",
"description": "Use failed_when and specify error conditions instead of using ignore_errors.",
"fingerprint": "67c3422690495f0e27a3b547b3cecfa8cd0e344c379b20ad63257d04b64031a2",
"location": {
"path": "build/stf-run-ci/tasks/pre-clean.yml",
"lines": {
"begin": 136
}
},
"content": {
"body": "Task/Handler: Remove Elasticsearch"
}
},
{
"type": "issue",
"check_name": "no-changed-when",
"categories": [
"command-shell",
"idempotency"
],
"url": "https://ansible-lint.readthedocs.io/rules/no-changed-when/",
"severity": "major",
"description": "Commands should not change things if nothing needs doing.",
"fingerprint": "77f4f35192fa593ea9ca1b77d8f55865780e7c087ca08f693033696570930d8e",
"location": {
"path": "build/stf-run-ci/tasks/preflight_checks.yml",
"lines": {
"begin": 2
}
},
"content": {
"body": "Task/Handler: Wait for Service Telemetry Operator to be Succeeded"
}
},
{
"type": "issue",
"check_name": "risky-shell-pipe",
"categories": [
"command-shell"
],
"url": "https://ansible-lint.readthedocs.io/rules/risky-shell-pipe/",
"severity": "major",
"description": "Shells that use pipes should set the pipefail option.",
"fingerprint": "ae3e8d3b7b7c414588d210ec39c1cd94819242b55423863a7cc38031258648f1",
"location": {
"path": "build/stf-run-ci/tasks/preflight_checks.yml",
"lines": {
"begin": 2
}
},
"content": {
"body": "Task/Handler: Wait for Service Telemetry Operator to be Succeeded"
}
},
{
"type": "issue",
"check_name": "name[missing]",
"categories": [
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/name/",
"severity": "major",
"description": "All tasks should be named.",
"fingerprint": "7671263e8facaf858533e7a56babfdcd44345d320767ea1cf6732aed618f72c6",
"location": {
"path": "build/stf-run-ci/tasks/setup_base.yml",
"lines": {
"begin": 32
}
},
"content": {
"body": "Task/Handler: block/always/rescue "
}
},
{
"type": "issue",
"check_name": "name[missing]",
"categories": [
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/name/",
"severity": "major",
"description": "All tasks should be named.",
"fingerprint": "6a6d6985ee9f1c409bf80ee09c1661576d93d43200dd446878dadedaed373645",
"location": {
"path": "build/stf-run-ci/tasks/setup_base.yml",
"lines": {
"begin": 71
}
},
"content": {
"body": "Task/Handler: block/always/rescue "
}
},
{
"type": "issue",
"check_name": "name[missing]",
"categories": [
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/name/",
"severity": "major",
"description": "All tasks should be named.",
"fingerprint": "5e202480c56a2958ff3114924a5b1eb9a8bdb258c18131a30dfbe9e6ee67e301",
"location": {
"path": "build/stf-run-ci/tasks/setup_base.yml",
"lines": {
"begin": 90
}
},
"content": {
"body": "Task/Handler: block/always/rescue "
}
},
{
"type": "issue",
"check_name": "yaml[new-line-at-end-of-file]",
"categories": [
"formatting",
"yaml"
],
"url": "https://ansible-lint.readthedocs.io/rules/yaml/",
"severity": "major",
"description": "No new line character at the end of file",
"fingerprint": "7c15cec5c352d8f54e3d0ae87a58f99840b51610fc698f5d75cec8e19f737904",
"location": {
"path": "build/stf-run-ci/tasks/setup_elasticsearch.yml",
"lines": {
"begin": 32
}
}
},
{
"type": "issue",
"check_name": "key-order[task]",
"categories": [
"formatting"
],
"url": "https://ansible-lint.readthedocs.io/rules/key-order/",
"severity": "major",
"description": "You can improve the task key order to: tags, block",
"fingerprint": "1dc9d4f8f8ca461e53cfe52d3a0be56261bffd026575fb426ea397727f39c4eb",
"location": {
"path": "build/stf-run-ci/tasks/setup_stf_from_bundles.yml",
"lines": {
"begin": 1
}
},
"content": {
"body": "Task/Handler: block/always/rescue "
}
},
{
"type": "issue",
"check_name": "name[missing]",
"categories": [
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/name/",
"severity": "major",
"description": "All tasks should be named.",
"fingerprint": "f6ad1b1014f6459728fec5a83b323e7037cf19f64119c894a0339719e639af89",
"location": {
"path": "build/stf-run-ci/tasks/setup_stf_from_bundles.yml",
"lines": {
"begin": 1
}
},
"content": {
"body": "Task/Handler: block/always/rescue "
}
},
{
"type": "issue",
"check_name": "command-instead-of-shell",
"categories": [
"command-shell",
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/command-instead-of-shell/",
"severity": "major",
"description": "Use shell only when shell functionality is required.",
"fingerprint": "1ec2b5fb071b6ad182cf4ce7373221af2cf9139df6561b77584bdf1314e2fccd",
"location": {
"path": "build/stf-run-ci/tasks/setup_stf_from_bundles.yml",
"lines": {
"begin": 91
}
},
"content": {
"body": "Task/Handler: Deploy SGO via OLM bundle"
}
},
{
"type": "issue",
"check_name": "no-changed-when",
"categories": [
"command-shell",
"idempotency"
],
"url": "https://ansible-lint.readthedocs.io/rules/no-changed-when/",
"severity": "major",
"description": "Commands should not change things if nothing needs doing.",
"fingerprint": "a492ed450ef7b351b277e0a9f36be1b67b4bed666f251a3f2ab6b015e2ec5181",
"location": {
"path": "build/stf-run-ci/tasks/setup_stf_from_bundles.yml",
"lines": {
"begin": 91
}
},
"content": {
"body": "Task/Handler: Deploy SGO via OLM bundle"
}
},
{
"type": "issue",
"check_name": "jinja[spacing]",
"categories": [
"formatting"
],
"url": "https://ansible-lint.readthedocs.io/rules/jinja/",
"severity": "minor",
"description": "Jinja2 spacing could be improved: {{ base_dir }}/working/operator-sdk run bundle {{__smart_gateway_bundle_image_path}} {% if pull_secret is defined %}--pull-secret-name=pull-secret --ca-secret-name=registry-tls-ca{% endif %} --namespace={{ namespace }} --timeout 600s -> {{ base_dir }}/working/operator-sdk run bundle {{ __smart_gateway_bundle_image_path }} {% if pull_secret is defined %}--pull-secret-name=pull-secret --ca-secret-name=registry-tls-ca{% endif %} --namespace={{ namespace }} --timeout 600s",
"fingerprint": "915d23e4d0d4b5728a57896c9f6bce3f425a6e098e6c5e1a9ffebe7e2a93ca67",
"location": {
"path": "build/stf-run-ci/tasks/setup_stf_from_bundles.yml",
"lines": {
"begin": 93
}
},
"content": {
"body": "Jinja2 template rewrite recommendation: `{{ base_dir }}/working/operator-sdk run bundle {{ __smart_gateway_bundle_image_path }} {% if pull_secret is defined %}--pull-secret-name=pull-secret --ca-secret-name=registry-tls-ca{% endif %} --namespace={{ namespace }} --timeout 600s`."
}
},
{
"type": "issue",
"check_name": "command-instead-of-shell",
"categories": [
"command-shell",
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/command-instead-of-shell/",
"severity": "major",
"description": "Use shell only when shell functionality is required.",
"fingerprint": "f2bf42df13014e3b448e7f396415b3c56827fc75b62ccd51d85f1f35bfe11f57",
"location": {
"path": "build/stf-run-ci/tasks/setup_stf_from_bundles.yml",
"lines": {
"begin": 95
}
},
"content": {
"body": "Task/Handler: Deploy STO via OLM bundle"
}
},
{
"type": "issue",
"check_name": "no-changed-when",
"categories": [
"command-shell",
"idempotency"
],
"url": "https://ansible-lint.readthedocs.io/rules/no-changed-when/",
"severity": "major",
"description": "Commands should not change things if nothing needs doing.",
"fingerprint": "49847cf9911839ff4c14d73a63ea51bb94e9945058be693fb9fa92d81ec6eee0",
"location": {
"path": "build/stf-run-ci/tasks/setup_stf_from_bundles.yml",
"lines": {
"begin": 95
}
},
"content": {
"body": "Task/Handler: Deploy STO via OLM bundle"
}
},
{
"type": "issue",
"check_name": "jinja[spacing]",
"categories": [
"formatting"
],
"url": "https://ansible-lint.readthedocs.io/rules/jinja/",
"severity": "minor",
"description": "Jinja2 spacing could be improved: {{ base_dir }}/working/operator-sdk run bundle {{ __service_telemetry_bundle_image_path}} {% if pull_secret is defined %}--pull-secret-name=pull-secret --ca-secret-name=registry-tls-ca{% endif %} --namespace={{ namespace }} --timeout 600s -> {{ base_dir }}/working/operator-sdk run bundle {{ __service_telemetry_bundle_image_path }} {% if pull_secret is defined %}--pull-secret-name=pull-secret --ca-secret-name=registry-tls-ca{% endif %} --namespace={{ namespace }} --timeout 600s",
"fingerprint": "8e9015c5972301b4552bebe353c655c948829aaa4742addf030e2184e25ccfbb",
"location": {
"path": "build/stf-run-ci/tasks/setup_stf_from_bundles.yml",
"lines": {
"begin": 97
}
},
"content": {
"body": "Jinja2 template rewrite recommendation: `{{ base_dir }}/working/operator-sdk run bundle {{ __service_telemetry_bundle_image_path }} {% if pull_secret is defined %}--pull-secret-name=pull-secret --ca-secret-name=registry-tls-ca{% endif %} --namespace={{ namespace }} --timeout 600s`."
}
},
{
"type": "issue",
"check_name": "no-changed-when",
"categories": [
"command-shell",
"idempotency"
],
"url": "https://ansible-lint.readthedocs.io/rules/no-changed-when/",
"severity": "major",
"description": "Commands should not change things if nothing needs doing.",
"fingerprint": "48b0a8cdd8f98ecbae123c62e712f765244221cfea45a3b99d8ec3c245adbacf",
"location": {
"path": "build/stf-run-ci/tasks/setup_stf_local_build.yml",
"lines": {
"begin": 6
}
},
"content": {
"body": "Task/Handler: Generate Smart Gateway Operator CSV"
}
},
{
"type": "issue",
"check_name": "name[missing]",
"categories": [
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/name/",
"severity": "major",
"description": "All tasks should be named.",
"fingerprint": "e652363b1cdcb8ab0f14b689f3786ba477b2a2ce76c9950cdf3e87bc36bb46c5",
"location": {
"path": "build/stf-run-ci/tasks/setup_stf_local_build.yml",
"lines": {
"begin": 36
}
},
"content": {
"body": "Task/Handler: block/always/rescue "
}
},
{
"type": "issue",
"check_name": "no-changed-when",
"categories": [
"command-shell",
"idempotency"
],
"url": "https://ansible-lint.readthedocs.io/rules/no-changed-when/",
"severity": "major",
"description": "Commands should not change things if nothing needs doing.",
"fingerprint": "c355513bf6eca384bddefe5fdb3378122758591637f330b475501a811df9e8fa",
"location": {
"path": "build/stf-run-ci/tasks/setup_stf_local_build.yml",
"lines": {
"begin": 38
}
},
"content": {
"body": "Task/Handler: Load Smart Gateway Operator RBAC"
}
},
{
"type": "issue",
"check_name": "command-instead-of-shell",
"categories": [
"command-shell",
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/command-instead-of-shell/",
"severity": "major",
"description": "Use shell only when shell functionality is required.",
"fingerprint": "cb9a1daf29fe90a3f67b0804ff983c215281bfac65c555cb86296b9ef8981c24",
"location": {
"path": "build/stf-run-ci/tasks/setup_stf_local_build.yml",
"lines": {
"begin": 47
}
},
"content": {
"body": "Task/Handler: Load Smart Gateway Operator CSV"
}
},
{
"type": "issue",
"check_name": "no-changed-when",
"categories": [
"command-shell",
"idempotency"
],
"url": "https://ansible-lint.readthedocs.io/rules/no-changed-when/",
"severity": "major",
"description": "Commands should not change things if nothing needs doing.",
"fingerprint": "5d235205da55cd66f43a8632c4c8dde7e25091b2d08d86eae705bab0fc1b514b",
"location": {
"path": "build/stf-run-ci/tasks/setup_stf_local_build.yml",
"lines": {
"begin": 47
}
},
"content": {
"body": "Task/Handler: Load Smart Gateway Operator CSV"
}
},
{
"type": "issue",
"check_name": "no-changed-when",
"categories": [
"command-shell",
"idempotency"
],
"url": "https://ansible-lint.readthedocs.io/rules/no-changed-when/",
"severity": "major",
"description": "Commands should not change things if nothing needs doing.",
"fingerprint": "dcd6e404bfeed8216cdcbcc418aaf372fa6bcc8367a3ec467d491aff70841d9a",
"location": {
"path": "build/stf-run-ci/tasks/setup_stf_local_build.yml",
"lines": {
"begin": 52
}
},
"content": {
"body": "Task/Handler: Generate Service Telemetry Operator CSV"
}
},
{
"type": "issue",
"check_name": "name[missing]",
"categories": [
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/name/",
"severity": "major",
"description": "All tasks should be named.",
"fingerprint": "8b862e59ca641a8ee4894c248bf3c511df46986732f95061f5f22258b63bfe27",
"location": {
"path": "build/stf-run-ci/tasks/setup_stf_local_build.yml",
"lines": {
"begin": 80
}
},
"content": {
"body": "Task/Handler: block/always/rescue "
}
},
{
"type": "issue",
"check_name": "no-changed-when",
"categories": [
"command-shell",
"idempotency"
],
"url": "https://ansible-lint.readthedocs.io/rules/no-changed-when/",
"severity": "major",
"description": "Commands should not change things if nothing needs doing.",
"fingerprint": "a348277a903417ca58bce76e0a56b5d33156f779281e8827961b6437b7e2f8fb",
"location": {
"path": "build/stf-run-ci/tasks/setup_stf_local_build.yml",
"lines": {
"begin": 82
}
},
"content": {
"body": "Task/Handler: Load Service Telemetry Operator RBAC"
}
},
{
"type": "issue",
"check_name": "command-instead-of-shell",
"categories": [
"command-shell",
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/command-instead-of-shell/",
"severity": "major",
"description": "Use shell only when shell functionality is required.",
"fingerprint": "ea1d40f5986aeaacc338b6c5c642663875d0a8f85ee7c10540411f1c7f5bf647",
"location": {
"path": "build/stf-run-ci/tasks/setup_stf_local_build.yml",
"lines": {
"begin": 91
}
},
"content": {
"body": "Task/Handler: Load Service Telemetry Operator CSV"
}
},
{
"type": "issue",
"check_name": "no-changed-when",
"categories": [
"command-shell",
"idempotency"
],
"url": "https://ansible-lint.readthedocs.io/rules/no-changed-when/",
"severity": "major",
"description": "Commands should not change things if nothing needs doing.",
"fingerprint": "c6c49d69cd9c370dc9ff96c4b402d4961f852eea4d650f229c1242c4f89ef596",
"location": {
"path": "build/stf-run-ci/tasks/setup_stf_local_build.yml",
"lines": {
"begin": 91
}
},
"content": {
"body": "Task/Handler: Load Service Telemetry Operator CSV"
}
},
{
"type": "issue",
"check_name": "command-instead-of-module",
"categories": [
"command-shell",
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/command-instead-of-module/",
"severity": "major",
"description": "git used in place of git module",
"fingerprint": "da2712f66f8dc9da0f728bc4ccef2c400332267f75a2b881387878484f4cf3e0",
"location": {
"path": "build/stf-run-ci/tasks/setup_stf_local_build.yml",
"lines": {
"begin": 96
}
},
"content": {
"body": "Task/Handler: Revert local change to role_binding.yaml"
}
},
{
"type": "issue",
"check_name": "command-instead-of-shell",
"categories": [
"command-shell",
"idiom"
],
"url": "https://ansible-lint.readthedocs.io/rules/command-instead-of-shell/",
"severity": "major",
"description": "Use shell only when shell functionality is required.",
"fingerprint": "7970c1ea0413ef015e776caf745e1a09a3cc784bd5bb277164bad7670b9994f0",
"location": {
"path": "build/stf-run-ci/tasks/setup_stf_local_build.yml",
"lines": {
"begin": 96
}
},
"content": {
"body": "Task/Handler: Revert local change to role_binding.yaml"
}
},
{
"type": "issue",
"check_name": "no-changed-when",
"categories": [
"command-shell",
"idempotency"
],
"url": "https://ansible-lint.readthedocs.io/rules/no-changed-when/",
"severity": "major",
"description": "Commands should not change things if nothing needs doing.",
"fingerprint": "c4bd41b970c4a724ede4e5ad610037c17081f2b2a589eb5c9d68d890b187a40f",
"location": {
"path": "build/stf-run-ci/tasks/setup_stf_local_build.yml",
"lines": {
"begin": 96
}
},
"content": {
"body": "Task/Handler: Revert local change to role_binding.yaml"
}
},
{
"type": "issue",
"check_name": "yaml[new-line-at-end-of-file]",
"categories": [
"formatting",
"yaml"
],
"url": "https://ansible-lint.readthedocs.io/rules/yaml/",
"severity": "major",
"description": "No new line character at the end of file",
"fingerprint": "f74796b7daccee2f91e639ddc858554ae84d141fd1f70c673c0ea3358cb8ba55",
"location": {
"path": "build/stf-run-ci/vars/main.yml",
"lines": {
"begin": 2
}
}
}
] |
elfiesmelfie
approved these changes
Sep 14, 2023
elfiesmelfie
added a commit
that referenced
this pull request
Sep 14, 2023
* [ansible-lint] Use fqcn for modules * command -> ansible.builtin.command * debug -> ansible.builtin.debug * file -> ansible.builtin.file * k8s -> kubernetes.core.k8s * k8s_info -> kubernetes.core.k8s_info * set_fact -> ansible.builtin.set_fact * shell -> ansible.builtin.shell * template -> ansible.builtin.template #455 * Add lint testing for stf-run-ci fqcn (#462) --------- Co-authored-by: Leif Madsen <lmadsen@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.