Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix static namespace reference #464

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Fix static namespace reference #464

merged 1 commit into from
Sep 14, 2023

Conversation

leifmadsen
Copy link
Member

Fix a static namespace reference introduced in #455

@leifmadsen
Fix static namespace reference
2b19ddf 
Fix a static namespace reference introduced in #455
elfiesmelfie
elfiesmelfie approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@elfiesmelfie elfiesmelfie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the PR that introduced this, and can't see any other namespace error introduced;

Approved, pending CI results

@leifmadsen
Copy link
Member Author

test

@elfiesmelfie elfiesmelfie merged commit 0d0dbec into master Sep 14, 2023
10 checks passed
@elfiesmelfie elfiesmelfie deleted the fix/this-is-why-you-run-ci branch September 14, 2023 16:01
@leifmadsen leifmadsen mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkmc vkmc vkmc approved these changes

@csibbitt csibbitt csibbitt approved these changes

@elfiesmelfie elfiesmelfie elfiesmelfie approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leifmadsen @vkmc @csibbitt @elfiesmelfie