Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stf-collect-logs] Add a role for log collection #488

Merged
merged 11 commits into from
Oct 17, 2023
Merged

[stf-collect-logs] Add a role for log collection #488

merged 11 commits into from
Oct 17, 2023

Conversation

elfiesmelfie
Copy link
Collaborator

No description provided.

@elfiesmelfie
Copy link
Collaborator Author

Jenkins says this doesn't break anything, but it needs some additional testing, I'm sure.

@elfiesmelfie elfiesmelfie marked this pull request as ready for review September 26, 2023 18:59
csibbitt
csibbitt approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@csibbitt csibbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"that should actually have broken something." Is this an open concern that jenkins failed to report a failure where you thought it should? Or did you figure out what happened?

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/da2ea036d7be462ca202f75bb080bd71

❌ stf-crc-latest-local_build RETRY_LIMIT in 15m 47s

@elfiesmelfie
Copy link
Collaborator Author

"that should actually have broken something." Is this an open concern that jenkins failed to report a failure where you thought it should? Or did you figure out what happened?

I'm only getting around to looking at it today. It'll be easier to test now that we have one of the Zuul jobs also running.

@elfiesmelfie
Copy link
Collaborator Author

recheck

The Zuul errors was related to CRC not starting. I'm assuming that was an intermittent failure for now.

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/048a6e72411e4dc6b6844ec30b36255e

❌ stf-crc-latest-local_build FAILURE in 15m 02s

@elfiesmelfie elfiesmelfie mentioned this pull request Oct 10, 2023
Merged
vkmc
vkmc approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@vkmc vkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vkmc
Copy link
Collaborator

vkmc commented Oct 17, 2023

This PR has been sitting there for a while, seems straightforward and already have three approvals, so I'll proceed to merge. Thanks Emma!

@vkmc vkmc merged commit d7f1708 into master Oct 17, 2023
9 checks passed
@vkmc vkmc deleted the efoley-add-collect-logs-role branch October 17, 2023 14:08
@leifmadsen leifmadsen mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csibbitt csibbitt csibbitt approved these changes

@vkmc vkmc vkmc approved these changes

@leifmadsen leifmadsen leifmadsen approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elfiesmelfie @vkmc @leifmadsen @csibbitt