Add optional spec.replaces field to CSV for update graph compliance #572
Conversation
The way we generate our CSVs uses OLM's skipRange functionality. This is fine, but using only this leads to older versions becoming unavailable after the fact -- see the warning at [1]. By adding an optional spec.replaces to our CSV we allow update testing as well as actual production updates for downstream builds that leverage it. Populating the field requires knowledge of the latest-released bundle, so we take it from an environment variable to be provided by the builder. If this is unset we don't include the spec.replaces field at all -- leaving previous behavior unchanged. Resolves #559 Related: STF-1658 [1] https://olm.operatorframework.io/docs/concepts/olm-architecture/operator-catalog/creating-an-update-graph/#skiprange (cherry picked from commit 99221fb)
|
Cherry-pick from the master branch #560 to ensure we pick this up before any other upcoming changes. |
|
Since the branch names match, jenkins will build this change and the sgo change. I've started a build |
There was a problem hiding this comment.
Same suggestions as infrawatch/smart-gateway-operator#157 (review) but I see these are both cherry-picks, so that comment belonged on the review that brought these to master. Feel free to ignore for now.
Addressed in that other review, see infrawatch/smart-gateway-operator#157 (comment) I agree completely but operator-sdk forces our hand unless we rework bundle generation in a major way. |
The way we generate our CSVs uses OLM's skipRange functionality. This is fine, but using only this leads to older versions becoming unavailable after the fact -- see the warning at [1].
By adding an optional spec.replaces to our CSV we allow update testing as well as actual production updates for downstream builds that leverage it.
Populating the field requires knowledge of the latest-released bundle, so we take it from an environment variable to be provided by the builder. If this is unset we don't include the spec.replaces field at all -- leaving previous behavior unchanged.
Resolves #559
Related: STF-1658
[1] https://olm.operatorframework.io/docs/concepts/olm-architecture/operator-catalog/creating-an-update-graph/#skiprange
(cherry picked from commit 99221fb)