maxOpenShiftVersion 4.12 in OLM properties #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leifmadsen
reviewed
Mar 6, 2023
| olm.properties: '[{"type": "olm.maxOpenShiftVersion", "value": "4.10"}]' | ||
| olm.properties: '[{"type": "olm.maxOpenShiftVersion", "value": "4.12"}]' |
There was a problem hiding this comment.
So this is something I messed up when I copied out of the CSV in the other PR. This first line should not exist in the properties.yaml. It was copied there for reference to know what to put in to the file, but I should have deleted it.
leifmadsen
reviewed
Mar 6, 2023
deploy/olm-catalog/smart-gateway-operator/metadata/properties.yaml
Outdated
Show resolved
Hide resolved
leifmadsen
approved these changes
Mar 6, 2023
csibbitt
added a commit
that referenced
this pull request
Mar 6, 2023
* Lock the bundle to OCP v4.10 (#125) * Fix the valid-subscription annotation (#127) * Expand support for OCP 4.11 (#130) * Changes for 4.12 (#134) * GHA checkout action v2 is deprecated (#135) The GitHub Actions checkout action v2 is deprecated and needs to move to version 3. * Implement changes for operator-sdk-1.26.0 testing (#137) * Implement changes for operator-sdk-1.26.0 testing Implement changes that allow testing validation via operator-sdk-1.26.0 without bumping the entire bundle generation process from operator-sdk-0.19.4 to post-operator-sdk-1.x. These are the same tests run for validation during product pipeline verification. * Adds test to verify building of the bundle image works. * Adds KinD deployment to allow executing scorecard checks. Related: STF-1252 * Simplify use of RELEASE_VERSION variable * maxOpenShiftVersion 4.12 in OLM properties (#138) * maxOpenShiftVersion 4.12 in OLM properties * Remove invalid line from properties.yaml --------- Co-authored-by: Leif Madsen <lmadsen@redhat.com> --------- Co-authored-by: Leif Madsen <lmadsen@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.