Add logs to generate bundle #143
Conversation
build/generate_bundle.sh
Outdated
| pushd "${REL}/../" > /dev/null 2>&1 | ||
| ${OPERATOR_SDK} generate bundle --channels ${BUNDLE_CHANNELS} --default-channel ${BUNDLE_DEFAULT_CHANNEL} --manifests --metadata --version "${OPERATOR_BUNDLE_VERSION}" --output-dir "${WORKING_DIR}" > /dev/null 2>&1 | ||
| popd > /dev/null 2>&1 | ||
| pushd "${REL}/../" >> ${LOGFILE} 2>&1 |
There was a problem hiding this comment.
Are the pushd / popd logs actually useful?
There was a problem hiding this comment.
Beats me, I'm trying to test whether I can use Depends-On with zuul. I have some additional changes to make in infrawatch/service-telemetry-operator#429 so that we can configure the destination dirs and not always try to clone the repos.
I'll have to check the usefulness of this output later
There was a problem hiding this comment.
Oh! They were useful when initially debugging, before I started using absolute dirs, since it was hard to tell where the commands were being executed.
This reverts commit 6829947. Depends-On: infrawatch/smart-gateway-operator#143
elfiesmelfie
changed the title
This reverts commit 6829947. Depends-On: infrawatch/smart-gateway-operator#143
This reverts commit 6829947. Depends-On: infrawatch/smart-gateway-operator#143
This reverts commit 6829947. Depends-On: infrawatch/smart-gateway-operator#143
This reverts commit 6829947. Depends-On: infrawatch/smart-gateway-operator#143
This reverts commit 6829947. Depends-On: infrawatch/smart-gateway-operator#143
This reverts commit 6829947. Depends-On: infrawatch/smart-gateway-operator#143
elfiesmelfie
changed the title
build/generate_bundle.sh
Outdated
| pushd "${REL}/../" > /dev/null 2>&1 | ||
| ${OPERATOR_SDK} generate bundle --channels ${BUNDLE_CHANNELS} --default-channel ${BUNDLE_DEFAULT_CHANNEL} --manifests --metadata --version "${OPERATOR_BUNDLE_VERSION}" --output-dir "${WORKING_DIR}" > /dev/null 2>&1 | ||
| popd > /dev/null 2>&1 | ||
| pushd "${REL}/../" >> ${LOGFILE} 2>&1 |
There was a problem hiding this comment.
Oh! They were useful when initially debugging, before I started using absolute dirs, since it was hard to tell where the commands were being executed.
build/generate_bundle.sh
Outdated
|
|
||
| sed -i -E "${REPLACE_REGEX}" "${WORKING_DIR}/manifests/${OPERATOR_NAME}.clusterserviceversion.yaml" | ||
| } | ||
|
|
||
| copy_extra_metadata() { | ||
| pushd "${REL}/../" > /dev/null 2>&1 | ||
| pushd "${REL}/../" >> ${LOGFILE} 2>&1 |
There was a problem hiding this comment.
I'll revert these lines, like in the STO generate_bundle.sh
build/generate_bundle.sh
Outdated
| @@ -42,6 +45,7 @@ build_bundle_instructions() { | |||
| } | |||
|
|
|||
|
|
|||
| ${OPERATOR_SDK} version | |||
There was a problem hiding this comment.
This was definitely for debugging, and helped eventually to figure out that there were multiple operator-sdk versions needed
| @@ -1,6 +1,9 @@ | |||
| #!/usr/bin/env bash | |||
| set -e | |||
| REL=$(dirname "$0") | |||
| set -x | |||
| LOGFILE=${LOGFILE:-/dev/null} | |||
There was a problem hiding this comment.
I need to truncate this, in case there's already a logfile present
|
This change is checked by Jenkins in infrawatch/service-telemetry-operator#463 both branches are checked out and tested together |
No description provided.