Add requires infrastructure annotations #146
Conversation
Add required infrastructure annotations for the bundle. Implementation is done in generate_bundle.sh because the annotations.yaml file in the deploy/olm-catalog/ directory is not read by operator-sdk-0.19.4. Append required additional feature annotations to the generated annotations.yaml by operator-sdk generate bundle. Related STF-1530
build/generate_bundle.sh
Outdated
| @@ -34,6 +34,18 @@ generate_bundle() { | |||
| popd > /dev/null 2>&1 | |||
|
|
|||
| sed -i -E "${REPLACE_REGEX}" "${WORKING_DIR}/manifests/${OPERATOR_NAME}.clusterserviceversion.yaml" | |||
| cat >> "${WORKING_DIR}/metadata/annotations.yaml" << EOF | |||
| features.operators.openshift.io/disconnected: "false" | |||
| features.operators.openshift.io/fips-compliant: "false" | |||
There was a problem hiding this comment.
My hunch is that we could run in a FIPS-140 environment, but I don't think we have any place to do explicit testing yet. Can shiftstack deploy OCP in fips mode? This might be trivial to try.
There was a problem hiding this comment.
Yea we have this spike (https://issues.redhat.com/browse/STF-1384) for STF + FIPS filed a long time ago. I think we were mostly waiting for our CI framework to get updated and make it easier to add different deployment environments.
This might be something we could look at doing as part of disconnected because we'll want our CI systems to deploy OCP in disconnected mode, and then work through installation of STF via disconnected mode as our default installation method. If it's relatively simple to put OCP into FIPS compatible mode as well, then we can layer FIPS + disconnected in the same environment.
build/generate_bundle.sh
Outdated
| features.operators.openshift.io/cnf: "false" | ||
| features.operators.openshift.io/cni: "false" | ||
| features.operators.openshift.io/csi: "false" | ||
| features.operators.openshift.io/tls-profiles: "false" |
There was a problem hiding this comment.
That's an RFE I've never considered before, but I can certainly see why it would be desirable!
I created https://issues.redhat.com/browse/STF-1554 in STF 2.0 to do an intentional walkthrough of the best practices so we can get closer to operating in ideal conditions. Thanks! |
|
Comment at infrawatch/service-telemetry-operator#499 (comment) also applicable here. More changes inbound. |
This reverts commit 8a9b2c6.
Add the required infrastructure annotations to the CSV directly, as that is the expected location for the new annotations. Related: STF-1530
|
Merging once infrawatch/service-telemetry-operator#499 passes all CI |
Add required infrastructure annotations for the bundle. Implementation
is done in generate_bundle.sh because the annotations.yaml file in the
deploy/olm-catalog/ directory is not read by operator-sdk-0.19.4. Append
required additional feature annotations to the generated
annotations.yaml by operator-sdk generate bundle.
Related STF-1530