Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features helpful for recipes with Big ingredients. #1481

Merged
merged 5 commits into from
May 3, 2023

Conversation

Tim-Linschoten
Copy link
Member

Created a getIngredient feature that allows getting 1 ingredient. This gives better performance when using Bakery.

Added wildcard support to the ingredient-filter to filter out all ingredients. This is helpful for recipe with a lot of big data.

…s gives better performance when using Bakery.

Added wildcard support to the ingredient-filter to filter out all ingredients. This is helpful for recipe with a lot of big data.
…am itself. Made a split between the filter used for the event stream and the GetIngredients.
@codecov-commenter
Copy link

Codecov Report

Merging #1481 (d8197e8) into master (30c613e) will decrease coverage by 0.50%.
The diff coverage is 50.68%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1481      +/-   ##
==========================================
- Coverage   81.35%   80.85%   -0.50%     
==========================================
  Files         137      137              
  Lines        4419     4466      +47     
  Branches      149      143       -6     
==========================================
+ Hits         3595     3611      +16     
- Misses        824      855      +31     
Impacted Files Coverage Δ
...n/scala/com/ing/baker/runtime/akka/AkkaBaker.scala 75.00% <0.00%> (-4.36%) ⬇️
...runtime/akka/actor/ClusterBakerActorProvider.scala 11.90% <0.00%> (-0.30%) ⬇️
...kka/actor/process_index/ProcessIndexProtocol.scala 100.00% <ø> (ø)
...tor/process_instance/ProcessInstanceProtocol.scala 27.77% <ø> (ø)
...ain/scala/com/ing/baker/runtime/model/BakerF.scala 38.12% <0.00%> (-1.23%) ⬇️
...e/akka/actor/process_index/ProcessIndexProto.scala 97.78% <33.33%> (-1.76%) ⬇️
.../actor/process_instance/ProcessInstanceProto.scala 92.66% <40.00%> (-3.77%) ⬇️
.../akka/actor/process_instance/ProcessInstance.scala 68.75% <68.18%> (-0.82%) ⬇️
...a/com/ing/baker/runtime/akka/AkkaBakerConfig.scala 77.77% <75.00%> (-0.17%) ⬇️
...untime/akka/actor/process_index/ProcessIndex.scala 85.16% <75.00%> (-0.31%) ⬇️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…on/BakerException.scala

Co-authored-by: Bas <bdegroot@protonmail.com>
@Tim-Linschoten Tim-Linschoten merged commit 60bf93a into master May 3, 2023
@Tim-Linschoten Tim-Linschoten deleted the big-ingredient-support-features branch May 3, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants