Skip to content

Commit

Permalink
fix(overlays): typescript errors
Browse files Browse the repository at this point in the history
Corrects typescript from `@popperjs/core` for overlays package
  • Loading branch information
bennypowers authored and daKmoR committed Jan 13, 2021
1 parent 70bfeba commit a7760b6
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .changeset/serious-candles-serve.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@lion/overlays': patch
---

Fix type declaration for \_\_syncFromPopperState method.
5 changes: 2 additions & 3 deletions packages/overlays/types/ArrowMixinTypes.d.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import { Constructor } from '@open-wc/dedupe-mixin';
import { LitElement, TemplateResult } from '@lion/core';
import { CSSResultArray } from '@lion/core';
import Data from 'popper.js';
import { Options as PopperOptions } from '@popperjs/core/lib/popper';
import { Options as PopperOptions, State } from '@popperjs/core/lib/popper';
import { OverlayConfig } from '../types/OverlayConfig';

export declare class ArrowHost {
Expand All @@ -25,7 +24,7 @@ export declare class ArrowHost {
_getPopperArrowConfig(popperConfigToExtendFrom: Partial<PopperOptions>): Partial<PopperOptions>;
__setupRepositionCompletePromise(): void;
get _arrowNode(): Element | null;
__syncFromPopperState(data: Data): void;
__syncFromPopperState(data: Partial<State>): void;
}

export declare function ArrowImplementation<T extends Constructor<LitElement>>(
Expand Down

0 comments on commit a7760b6

Please sign in to comment.