-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add keyboard navigation over disabled days #468
Conversation
- @lion/button@0.1.25 - @lion/calendar@0.1.21 - @lion/checkbox-group@0.1.23 - @lion/checkbox@0.1.21 - @lion/choice-input@0.1.21 - @lion/field@0.1.21 - @lion/fieldset@0.1.21 - @lion/form-system@0.0.24 - @lion/form@0.1.23 - @lion/input-amount@0.1.21 - @lion/input-date@0.1.21 - @lion/input-datepicker@0.1.18 - @lion/input-email@0.1.21 - @lion/input-iban@0.1.22 - @lion/input@0.1.21 - @lion/overlays@0.2.6 - @lion/popup@0.1.25 - @lion/radio-group@0.1.23 - @lion/radio@0.1.21 - @lion/select@0.1.21 - @lion/textarea@0.1.21 - @lion/tooltip@0.1.25 - @lion/validate@0.2.9
I will do an update on this. (after #499) |
Hi Ovidiu, We had a meeting as a team discussing the accessibility concerns with this keyboard navigation over disabled, and came to an agreement on the approach:
It's up to you whether you want to continue on this branch / PR or if you want to start a new one. If you do start a new one I think it would be wise to maybe start with tests first that align with the approach I mentioned above, get the okay, and then implement and fix failing tests. |
Ovidiu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
I will close this PR and i will start a new one. |
Feature Details:
Disabled days are now navigable via keyboard.
Display tooltip on focus (only on disable days)
Set "Unavailable" on the accessible name (only on disable days)
Tested: