Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keyboard navigation over disabled days #468

Closed

Conversation

ovidiu1
Copy link
Contributor

@ovidiu1 ovidiu1 commented Jan 1, 2020

Feature Details:

  • Disabled days are now navigable via keyboard.

  • Display tooltip on focus (only on disable days)

  • Set "Unavailable" on the accessible name (only on disable days)

Tested:

  • Chrome
  • IE 11
    lion-calendar

@ovidiu1 ovidiu1 changed the title Fix skipped disabled dates calendar add keyboard navigation over disabled days Jan 1, 2020
ovidiu1 and others added 3 commits January 1, 2020 21:30
 - @lion/button@0.1.25
 - @lion/calendar@0.1.21
 - @lion/checkbox-group@0.1.23
 - @lion/checkbox@0.1.21
 - @lion/choice-input@0.1.21
 - @lion/field@0.1.21
 - @lion/fieldset@0.1.21
 - @lion/form-system@0.0.24
 - @lion/form@0.1.23
 - @lion/input-amount@0.1.21
 - @lion/input-date@0.1.21
 - @lion/input-datepicker@0.1.18
 - @lion/input-email@0.1.21
 - @lion/input-iban@0.1.22
 - @lion/input@0.1.21
 - @lion/overlays@0.2.6
 - @lion/popup@0.1.25
 - @lion/radio-group@0.1.23
 - @lion/radio@0.1.21
 - @lion/select@0.1.21
 - @lion/textarea@0.1.21
 - @lion/tooltip@0.1.25
 - @lion/validate@0.2.9
package.json Outdated Show resolved Hide resolved
@ovidiu1
Copy link
Contributor Author

ovidiu1 commented Jan 18, 2020

I will do an update on this. (after #499)

@jorenbroekema
Copy link
Collaborator

jorenbroekema commented Feb 27, 2020

Hi Ovidiu,

We had a meeting as a team discussing the accessibility concerns with this keyboard navigation over disabled, and came to an agreement on the approach:

  • Instead of using <button>, use <div> with role=“button“
  • Use disabled attribute for styling this div
  • Use aria-disabled for screen readers (I don't think the unavailable tooltip is necessary then)
  • Manage click/enter/space events manually (adding listeners)

It's up to you whether you want to continue on this branch / PR or if you want to start a new one. If you do start a new one I think it would be wise to maybe start with tests first that align with the approach I mentioned above, get the okay, and then implement and fix failing tests.

@claassistantio
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ovidiu1
❌ Ovidiu


Ovidiu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ovidiu1
Copy link
Contributor Author

ovidiu1 commented Mar 5, 2020

I will close this PR and i will start a new one.

@ovidiu1 ovidiu1 closed this Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants