Skip to content

Contributing & PR Guidelines

Juan José Scarafía edited this page Sep 1, 2015 · 1 revision

Contributing Guidelines

We follow same guidelines than OCA Please read: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#version-numbers

PR Guidelines

  1. Make sure you target the right branch
  2. Keep your changes minimal, and strictly related to your issue (make other PRs if needed)
  3. Match the style of the surrounding code, in terms of whitespace, wrapping, etc.
  4. There are restrictions on the kind of changes allowed in stable series
  5. Explain why you are doing a change, not what (should be understandable from the diff)
  6. TODO (not yet implemented) Do not use Pull Requests to update translations, this is done using an external system (See our GitHub Transition page for details)
  7. Minimal commits! Rebase and squash your changes whenever you modify your PR and before submitting
  8. No conflicts! Rebase off the target branch just before submitting
  9. Check on your PR that all tests are green