implementation of the csrf signed double submit pattern #3409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Thonagel <12283268+thoniTUB@users.noreply.github.com>
|
Todo:
|
awildturtok
reviewed
Apr 25, 2024
| public static final String CSRF_TOKEN_PROPERTY = "csrf_token"; | ||
| public static final int TOKEN_LENGTH = 30; | ||
|
|
||
| Random random = new SecureRandom(); |
Signed-off-by: Max Thonagel <12283268+thoniTUB@users.noreply.github.com>
Signed-off-by: Max Thonagel <12283268+thoniTUB@users.noreply.github.com>
Signed-off-by: Max Thonagel <12283268+thoniTUB@users.noreply.github.com>
Signed-off-by: Max Thonagel <12283268+thoniTUB@users.noreply.github.com>
Signed-off-by: Max Thonagel <12283268+thoniTUB@users.noreply.github.com>
Signed-off-by: Max Thonagel <12283268+thoniTUB@users.noreply.github.com>
thoniTUB
changed the title
awildturtok
approved these changes
Apr 29, 2024
| null, | ||
| 0, | ||
| null, | ||
| 3600, |
There was a problem hiding this comment.
magic number auf der TTL?
| final StopWatch stopwatch = new StopWatch("Generate csrf token"); | ||
|
|
||
| stopwatch.start(); | ||
| final Hash hash = Password.hash(csrfToken).addRandomSalt(32).with(HASH_FUNCTION); |
backend/src/main/java/com/bakdata/conquery/models/auth/web/csrf/CsrfTokenSetFilter.java
Outdated
Show resolved
Hide resolved
Comment on lines
98
to
103
| final StopWatch stopwatch = new StopWatch("Check csrf token"); | ||
| stopwatch.start(); | ||
| final boolean decision = Password.check(token, saltedHash).addSalt(salt).with(HASH_FUNCTION); | ||
| stopwatch.stop(); | ||
|
|
||
| log.trace("Checked token in {}", stopwatch); |
…f/CsrfTokenSetFilter.java Co-authored-by: awildturtok <1553491+awildturtok@users.noreply.github.com>
Signed-off-by: Max Thonagel <12283268+thoniTUB@users.noreply.github.com>
order filter priorities remove csrf-check property Signed-off-by: Max Thonagel <12283268+thoniTUB@users.noreply.github.com>
|
@awildturtok mir war noch ein Problem, mit der Redirection nach einer Authentifizierung aufgefallen, welches ich jetzt gefixt habe. Mergen werde ich aber erst nach dem heutigen release |
Signed-off-by: Max Thonagel <12283268+thoniTUB@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.