Implement COUNT_QUARTERS select and filter for dateranges #3446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnsrnhld
commented
May 17, 2024
| } | ||
|
|
||
| @Override | ||
| public Aggregator<?> createAggregator() { | ||
|
|
||
| // TODO createAggregator() is called when resolving a query, but we don't need it besides for getResultType() |
There was a problem hiding this comment.
FYI: Fabian hatte mal gesagt, er wolle sich anschauen wie man das lösen kann. Deswegen hab ich es erstmal so gelassen.
There was a problem hiding this comment.
Ist seit gestern gelöst
thoniTUB
reviewed
May 21, 2024
Comment on lines
70
to
71
| if (isSingleColumnDaterange() && getColumn().getType() == MajorTypeId.DATE_RANGE) { | ||
| throw new UnsupportedOperationException("COUNT_QUARTERS conversion on columns of type DATE_RANGE not supported"); |
There was a problem hiding this comment.
Ich dachte, das mit der DateRange-Column wäre SQL-Dailect abhängig, also dass es für Postgres im Prinzip funktioniert
jnsrnhld
force-pushed
the
sql/feature/count-quarters-for-daterange-colums
branch
from
6c86152 to
3ede582
Compare
jnsrnhld
changed the base branch from
develop
to
sql/refactoring/rework-select-and-filter-conversion
Base automatically changed from
sql/refactoring/rework-select-and-filter-conversion
to
develop
June 13, 2024 07:34
…-daterange-colums # Conflicts: # backend/src/main/java/com/bakdata/conquery/apiv1/query/concept/filter/FilterValue.java # backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/filters/Filter.java # backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/filters/specific/BigMultiSelectFilter.java # backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/filters/specific/CountFilter.java # backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/filters/specific/CountQuartersFilter.java # backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/filters/specific/DateDistanceFilter.java # backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/filters/specific/FlagFilter.java # backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/filters/specific/MultiSelectFilter.java # backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/filters/specific/NumberFilter.java # backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/filters/specific/SingleSelectFilter.java # backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/filters/specific/SumFilter.java # backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/select/Select.java # backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/select/concept/specific/EventDateUnionSelect.java # backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/select/concept/specific/EventDurationSumSelect.java # backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/select/concept/specific/ExistsSelect.java # backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/select/connector/FirstValueSelect.java # backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/select/connector/LastValueSelect.java # backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/select/connector/RandomValueSelect.java # backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/select/connector/specific/CountQuartersSelect.java # backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/select/connector/specific/CountSelect.java # backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/select/connector/specific/DateDistanceSelect.java # backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/select/connector/specific/FlagSelect.java # backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/select/connector/specific/SumSelect.java # backend/src/main/java/com/bakdata/conquery/sql/conversion/cqelement/concept/CQConceptConverter.java # backend/src/main/java/com/bakdata/conquery/sql/conversion/cqelement/concept/TablePath.java # backend/src/main/java/com/bakdata/conquery/sql/conversion/model/aggregator/CommonAggregationSelect.java # backend/src/main/java/com/bakdata/conquery/sql/conversion/model/aggregator/CountQuartersSqlAggregator.java # backend/src/main/java/com/bakdata/conquery/sql/conversion/model/aggregator/CountSqlAggregator.java # backend/src/main/java/com/bakdata/conquery/sql/conversion/model/aggregator/SumSqlAggregator.java
awildturtok
approved these changes
Jun 13, 2024
| } | ||
|
|
||
| @Override | ||
| public Aggregator<?> createAggregator() { | ||
|
|
||
| // TODO createAggregator() is called when resolving a query, but we don't need it besides for getResultType() |
There was a problem hiding this comment.
Ist seit gestern gelöst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.