Implement external ID lookup for SQL mode #3496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awildturtok
reviewed
Jul 16, 2024
...main/java/com/bakdata/conquery/apiv1/query/concept/specific/external/EntityResolverUtil.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/com/bakdata/conquery/integration/json/ConqueryTestSpec.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/com/bakdata/conquery/integration/json/ConqueryTestSpec.java
Outdated
Show resolved
Hide resolved
awildturtok
requested changes
Jul 25, 2024
|
|
||
| String resolvedId = null; | ||
| for (Function<String[], EntityIdMap.ExternalId> reader : readers) { | ||
| final EntityIdMap.ExternalId externalId = reader.apply(row); |
There was a problem hiding this comment.
Glaube der Lesbarkeit halber solltest du die ExternalId von EntityIdMap entkoppeln oder zumindest die IdReader von der EntityIdMap. Ich lese den Code gerade und rätsele die ganze Zeit was du mit der EntityIdMap machst (die du ja nicht zur verfügung haben wirst).
awildturtok
approved these changes
Jul 25, 2024
thoniTUB
pushed a commit
that referenced
this pull request
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.