cleanup money #3535
Merged
cleanup money #3535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ResultType is now very simple mix of primitive enum and LIST. (We hope to remove even more logic from it) - Result printing was always weird with Mappings embedded in StringT. We've moved that responsibility into ResultInfo via SelectResultInfo for mapped Selects. - This PR opens the possibility to embed anonymization into the ResultInfo. - PrintSettings now caches the C10n calls as they were before that sometimes invoked per cell, which should make rendering faster.
…or QueryStatisticsTest
|
@thoniTUB ich hab hier vergessen einen neuen Branch zu starten, da das Money ding auch in die gleiche Schiene ist, ist das glaube nicht besonders schlimm. Aber einfach nervig. Ich kann wenn es dich stört nochmal versuchen es auseinander zu dröseln. |
… storage primitive. Is now BigDecimal
We inject the result specific Printers using the printerFactory. This untangles the burden of formatting. Now a Select claiming to produce a specific type only needs to guarantee they are in a format capable of being handled by the printers it elects to use. This allows us later to make a printer that alters the result before printing it, without having to inject into all renderers.
awildturtok
force-pushed
the
feature/cleanup-MONEY
branch
from
2208753 to
2122da5
Compare
awildturtok
changed the base branch from
feature/decouple-printing-from-ResultTyoe
to
develop
awildturtok
force-pushed
the
feature/cleanup-MONEY
branch
from
8fd7f53 to
9ee0f68
Compare
awildturtok
force-pushed
the
feature/cleanup-MONEY
branch
from
764e2f6 to
23a6b14
Compare
awildturtok
commented
Sep 3, 2024
backend/src/main/java/com/bakdata/conquery/io/result/parquet/EntityResultWriteSupport.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/models/events/stores/specific/MoneyIntStore.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/apiv1/query/TableExportQuery.java
Show resolved
Hide resolved
thoniTUB
reviewed
Sep 4, 2024
backend/src/main/java/com/bakdata/conquery/apiv1/query/ArrayConceptQuery.java
Show resolved
Hide resolved
| @@ -80,14 +82,15 @@ private static List<ColumnConsumer> generateColumnConsumers(List<ResultInfo> idH | |||
| return consumers; | |||
| } | |||
|
|
|||
| private static List<Printer> generateColumnPrinters(List<ResultInfo> idHeaders, List<ResultInfo> resultInfos, PrintSettings printSettings) { | |||
| private static List<Printer> generateColumnPrinters(List<ResultInfo> idHeaders, List<ResultInfo> resultInfos, PrintSettings printSettings, | |||
| PrinterFactory printerFactory) { | |||
There was a problem hiding this comment.
verstehe den hinweuis nicht aber habe die methode aufgeräumt
thoniTUB
reviewed
Sep 4, 2024
backend/src/main/java/com/bakdata/conquery/io/result/arrow/ResultArrowProcessor.java
Show resolved
Hide resolved
thoniTUB
reviewed
Sep 4, 2024
...kdata/conquery/models/datasets/concepts/select/connector/specific/CountOccurencesSelect.java
Outdated
Show resolved
Hide resolved
backend/src/test/resources/tests/sql/filter/number_money/real_range/number_money.spec.json
Outdated
Show resolved
Hide resolved
This reverts commit 6358f64.
…d other dependencies
awildturtok
force-pushed
the
feature/cleanup-MONEY
branch
from
1e101b6 to
efa20ba
Compare
thoniTUB
approved these changes
Sep 17, 2024
| @@ -31,6 +30,7 @@ public ObjectMapper createWorkerPersistenceMapper(Workers workers) { | |||
| final ObjectMapper objectMapper = createInternalObjectMapper(View.Persistence.Shard.class); | |||
|
|
|||
| workers.injectInto(objectMapper); | |||
| config.injectInto(objectMapper); | |||
There was a problem hiding this comment.
fehlte das beim injecten irgendwo?
There was a problem hiding this comment.
Muss schauen ob es das war, aber brauche ich um den MoneyIntStore die decimal stelle zu fixen
There was a problem hiding this comment.
Sorry, wollte den Kommentar eigentlich wieder löschen. Hatte danach die Injection gesehen
There was a problem hiding this comment.
Keine Sorge, ich glaube die config ist schon woanders injiziert. Muss das auf jeden Fall testen
There was a problem hiding this comment.
Ist der irrelevant geworden?
There was a problem hiding this comment.
ja, der hat money mit einer REAL_RANGE gefiltert.
# Conflicts: # backend/src/main/java/com/bakdata/conquery/models/query/SingleTableResult.java # backend/src/main/java/com/bakdata/conquery/models/query/preview/EntityPreviewExecution.java # backend/src/main/java/com/bakdata/conquery/models/query/resultinfo/ResultInfo.java # backend/src/main/java/com/bakdata/conquery/models/query/resultinfo/printers/ResultPrinters.java # backend/src/test/java/com/bakdata/conquery/integration/common/IntegrationUtils.java # backend/src/test/java/com/bakdata/conquery/integration/json/FormTest.java # backend/src/test/java/com/bakdata/conquery/io/result/ResultTestUtil.java # backend/src/test/java/com/bakdata/conquery/io/result/excel/ExcelResultRenderTest.java # backend/src/test/java/com/bakdata/conquery/models/events/stores/types/ColumnStoreSerializationTests.java # backend/src/test/java/com/bakdata/conquery/models/types/ResultTypeTest.java
awildturtok
force-pushed
the
feature/cleanup-MONEY
branch
from
945f4e7 to
256b651
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… storage primitive. Is now BigDecimal