use plain object for exception mapping #3647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awildturtok
reviewed
Jan 13, 2025
backend/src/main/java/com/bakdata/conquery/io/jetty/ConqueryErrorExceptionMapper.java
Show resolved
Hide resolved
thoniTUB
commented
Jan 13, 2025
| @@ -48,8 +48,7 @@ | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-compiler-plugin</artifactId> | |||
| <configuration> | |||
| <source>${java.required}</source> | |||
| <target>${java.required}</target> | |||
| <release>${java.required}</release> | |||
There was a problem hiding this comment.
@awildturtok bevor ich E2E bei mir lokal wieder zum Laufen bringen konnte hatte ich Probleme das Backend zu kompilieren.
In den Maven-Logs mit Java 23 gabs eine Warning à la: Lieber release nutzen als source+target da sonst nicht sicher gestellt wird, dass die richtigen System-Libs genutzt werden.
Durch das ändern war mein eigentlicher Fehler zwar nicht weggegangen, aber eine Warning weniger :)
|
|
|
noch offen? |
|
@awildturtok jam bitte reviewen |
awildturtok
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before we sent an object containing the stacktrace but no message