Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credentials not retained in config #4

Open
RutgerBeyen opened this issue Nov 5, 2019 · 3 comments
Open

Credentials not retained in config #4

RutgerBeyen opened this issue Nov 5, 2019 · 3 comments

Comments

@RutgerBeyen
Copy link

RutgerBeyen commented Nov 5, 2019 •
edited
Loading

The credentials specified under Source Code Management -> Git -> Additional Behaviours -> AWS CodeCommit URL Helper are not retained. When I input the credentials and save the build configuration, exit the page and re-enter the build configuration, no credentials are listed in the build configuration.
However, having a look at the raw build configuration file on the filesystem, the credential is referenced as it should be:
<submoduleCfg class="list"/> <extensions> <br.com.ingenieux.jenkins.plugins.codecommit.CodeCommitURLHelper plugin="codecommit-url-helper@0.0.3"> <credentialId>e************</credentialId> </br.com.ingenieux.jenkins.plugins.codecommit.CodeCommitURLHelper> </extensions>

If you happen to make any other change in the build configuration and save the page again, credential is lost:
<credentialId></credentialId>
and the build fails.

Same as #3 (comment)
@blockjon
Copy link

Confirmed this is still broken.

@LEDfan LEDfan mentioned this issue Mar 25, 2021
Closed
@LEDfan
Copy link

LEDfan commented Mar 25, 2021 •
edited
Loading

@RutgerBeyen @blockjon I created a PR at that fixes this issue see #6

matt2005 added a commit to matt2005/codecommit-url-helper that referenced this issue Jan 20, 2022
@matt2005 @LEDfan
Fix not retaining credentialid (#2)
2886222 
* Fix: credentialId was not retained in config

Fixes ingenieux#4

Steps to reproduce:

1. specify credentialId in configure page
2. save
3. reload page
4. credentialId has gone, but should still be there

* Fix: no getter found for repositoryName

Exception is thrown when trying to export the configuration of this
plugin using the Jenkins CasC plugin.

* Fix: make it possible to use CodeCommitHelper for a Shared Library

Co-authored-by: Tobia De Koninck <tobia.dekoninck@openanalytics.eu>
@matt2005
Copy link

Fixed in #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: credentialId was not retained in config
4 participants
@blockjon @matt2005 @LEDfan @RutgerBeyen