Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: credentialId was not retained in config #6

Closed
wants to merge 3 commits into from
Closed

Fix: credentialId was not retained in config #6

wants to merge 3 commits into from

Conversation

LEDfan
Copy link

@LEDfan LEDfan commented Mar 25, 2021

Fixes #4

Steps to reproduce:

  1. specify credentialId in configure page
  2. save
  3. reload page
  4. credentialId has gone, but should still be there

@LEDfan
Fix: credentialId was not retained in config
5af7198 
Fixes #4

Steps to reproduce:

1. specify credentialId in configure page
2. save
3. reload page
4. credentialId has gone, but should still be there
@LEDfan LEDfan mentioned this pull request Mar 25, 2021
Open
@LEDfan
Copy link
Author

LEDfan commented Mar 25, 2021

@aldrinleal is this the correct repo to submit the PR too, or should I submit it to the JenkinsCI fork?

@LEDfan
Fix: no getter found for repositoryName
3f0eceb 
Exception is thrown when trying to export the configuration of this
plugin using the Jenkins CasC plugin.
@LEDfan
Fix: make it possible to use CodeCommitHelper for a Shared Library
3c04edc
@aldrinleal
Copy link
Member

Yes its here. Will take a look thanks! :)

@LEDfan
Copy link
Author

LEDfan commented Mar 26, 2021

Thanks! In the meantime I also pushed two others commits:

  • a similar getter was missing for the repositoryName property. This gave an exception when you try to export the Jenkins configuration using the [jcasc}(https://github.com/jenkinsci/configuration-as-code-plugin) plugin. (e.g. when you would define the CodeCommitHelper as additional behaviour on a GlobalLibrary.)
  • I'm not sure whether we actually need that repositoryName property as it seems to me that it is never used?
  • the second fix makes it possible to select an AWS credential when using the helper for Global Libraries. In that case the Item is null (since the configuration is not tied to a Job), I simply splitted out the check for a null item and returned all available credentials. Do you think this a proper solution?

BTW thanks for this plugin, it really helped us in our project!

@LEDfan LEDfan closed this by deleting the head repository Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Credentials not retained in config
2 participants
@LEDfan @aldrinleal