-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't warn about overwriting controllers when hot-reloading code #81
Comments
There are a few different things to consider here. There are several types of messages here that could benefit from a more fine tuned config. Starting and stopping of controllers, data diffs etc. I'm considering adding support for a map in the
You are probably right that it doesn't make much sense to update+merge, don't know why I wrote it that way. Will switch to assoc and see how it works. |
It's hard to say no for more logging. :) |
A similar issue in
re-frame
: day8/re-frame#204A workaround is pretty much the same. And I guess when that issue becomes closed, this one could be closed as well with a similar or same solution.
A side-note: while the warning tells users about overwriting a controller, in fact a merge is happening. I'm not sure if update+merge is supposed to be there instead of simple assoc.
The text was updated successfully, but these errors were encountered: