Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: Golang Bindings for pinned host memory #519

Merged
merged 11 commits into from
Jun 24, 2024
Merged

[FEAT]: Golang Bindings for pinned host memory #519

merged 11 commits into from
Jun 24, 2024

Conversation

jeremyfelder
Copy link
Collaborator

@jeremyfelder jeremyfelder commented May 16, 2024 •
edited
Loading

Describe the changes

This PR adds the capability to pin host memory in golang bindings allowing data transfers to be quicker. Memory can be pinned once for multiple devices by passing the flag cuda_runtime.CudaHostRegisterPortable or cuda_runtime.CudaHostAllocPortable depending on how pinned memory is called

TODO

  • Rust bindings

Linked Issues

Resolves #43

@jeremyfelder jeremyfelder marked this pull request as ready for review June 5, 2024 13:00
yshekel
yshekel requested changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@yshekel yshekel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the Rust part only

@jeremyfelder jeremyfelder changed the title [FEAT]: Bindings for pinned host memory [FEAT]: Golang Bindings for pinned host memory Jun 19, 2024
@jeremyfelder jeremyfelder merged commit 2b07513 into main Jun 24, 2024
25 checks passed
@jeremyfelder jeremyfelder deleted the feat/pinned-host-mem branch June 24, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonHibnik LeonHibnik LeonHibnik approved these changes

@yshekel yshekel yshekel approved these changes

@nonam3e nonam3e Awaiting requested review from nonam3e

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pinned host memory
3 participants
@jeremyfelder @yshekel @LeonHibnik