fix large (>512 elements) ecntt issue #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is that cuda blocks are too large and cannot be placed on SMs. Fix is to reduce thread count per block and increase block count.
yshekel
requested review from
vhnatyk,
ChickenLover,
HadarIngonyama and
LeonHibnik
vhnatyk
approved these changes
Jul 4, 2024
HadarIngonyama
approved these changes
Jul 4, 2024
I also was wondering that, but I assumed maybe it performed better so that's why it as done like that. Also I would have to measure and see that I did not degrade anything so wanted to avoid that right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves an issue for large ecntt where cuda blocks are too large and cannot be assigned to SMs. The fix is to reduce thread count per block and increase block count in that case.