Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tasks manager classes to ease multithreading for cpu #573

Merged
merged 7 commits into from
Aug 11, 2024
Merged

Add tasks manager classes to ease multithreading for cpu #573

merged 7 commits into from
Aug 11, 2024

Conversation

Koren-Brand
Copy link
Contributor

@Koren-Brand Koren-Brand commented Aug 6, 2024 •
edited by yshekel
Loading

Added tasks_manager.h - a small library to aid multithreaded CPU coding.

@Koren-Brand Koren-Brand marked this pull request as ready for review August 6, 2024 08:58
mickeyasa
mickeyasa reviewed Aug 6, 2024
View reviewed changes
Copy link
Contributor

@mickeyasa mickeyasa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Koren, please add much more descriptions.
Especially for the functionality that the user is aware of

icicle_v3/backend/cpu/include/tasks_manager.h Outdated Show resolved Hide resolved
icicle_v3/backend/cpu/include/tasks_manager.h Outdated Show resolved Hide resolved
icicle_v3/backend/cpu/include/tasks_manager.h Outdated Show resolved Hide resolved
icicle_v3/backend/cpu/include/tasks_manager.h Outdated Show resolved Hide resolved
icicle_v3/backend/cpu/include/tasks_manager.h Outdated Show resolved Hide resolved
icicle_v3/backend/cpu/include/tasks_manager.h Outdated Show resolved Hide resolved
@Koren-Brand
fixes according to our meeting, that are yet to be tested on any actu…
e6621cd 
…al use case

will test on msm_test and update for the pr
LeonHibnik
LeonHibnik reviewed Aug 7, 2024
View reviewed changes
icicle_v3/backend/cpu/include/tasks_manager.h Outdated Show resolved Hide resolved
icicle_v3/backend/cpu/include/tasks_manager.h Outdated Show resolved Hide resolved
icicle_v3/backend/cpu/include/tasks_manager.h Outdated Show resolved Hide resolved
yshekel
yshekel reviewed Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@yshekel yshekel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better. Please address last comments and we can merge

@yshekel yshekel changed the title Added tasks manager classes to ease multithreading for cpu add tasks manager classes to ease multithreading for cpu Aug 11, 2024
@yshekel yshekel changed the title add tasks manager classes to ease multithreading for cpu Add tasks manager classes to ease multithreading for cpu Aug 11, 2024
@Koren-Brand Koren-Brand merged commit 0712d79 into yshekel/V3 Aug 11, 2024
18 checks passed
@Koren-Brand Koren-Brand deleted the v3-tasks-manager-for-multithreading branch August 11, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonHibnik LeonHibnik LeonHibnik left review comments

@mickeyasa mickeyasa mickeyasa left review comments

@yshekel yshekel yshekel approved these changes

@ShanieWinitz ShanieWinitz Awaiting requested review from ShanieWinitz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Koren-Brand @yshekel @mickeyasa @LeonHibnik