example and documentation for Merkle-tree API #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshekel
force-pushed
the
yshekel/merkle_example
branch
from
0ef12b5
to
d5daa4c
Compare
yshekel
force-pushed
the
yshekel/merkle_example
branch
from
d5daa4c
to
cc35bc3
Compare
yshekel
requested review from
ChickenLover,
jeremyfelder,
emirsoyturk and
Koren-Brand
yshekel
force-pushed
the
yshekel/merkle_example
branch
from
ff8bd49
to
1213f10
Compare
Koren-Brand
reviewed
Oct 14, 2024
|
|
||
| :::note | ||
| Any combination of hashes is valid including **Poseidon** that computes on field elements. |
There was a problem hiding this comment.
Are there any limitations on Poseidon in the tree (Odd bit width for example messing with the layer width)?
There was a problem hiding this comment.
I think that the field size must divide the output size of previous layer. But this is true for all other hashes too.
About converting random data to field elements it's the responsibility of the hasher function, not the tree.
Koren-Brand
reviewed
Oct 14, 2024
Koren-Brand
reviewed
Oct 14, 2024
Koren-Brand
reviewed
Oct 14, 2024
yshekel
changed the title
yshekel
force-pushed
the
yshekel/merkle_example
branch
from
9dd749d
to
d3f5cf8
Compare
mickeyasa
reviewed
Oct 16, 2024
mickeyasa
reviewed
Oct 16, 2024
mickeyasa
reviewed
Oct 16, 2024
|
|
||
| ## What is a Merkle Tree? | ||
|
|
||
| A **Merkle tree** is a cryptographic data structure that allows for **efficient verification of data integrity**. It consists of: |
There was a problem hiding this comment.
do you realy need to copy paste this section per API?
There was a problem hiding this comment.
I will link the rust to general part for the intro. The rest I will have some duplication but otherwise rust has not text at all. Makes sense?
mickeyasa
reviewed
Oct 16, 2024
|
comment |
mickeyasa
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.